Skipping tests with expired certificate

grantnelson-wf · grantnelson-wf · commit 75ff10ca9e14 · 2025-02-10T11:47:29.000-07:00
diff --git a/compiler/natives/src/crypto/tls/handshake_test.go b/compiler/natives/src/crypto/tls/handshake_test.go
@@ -10,7 +10,7 @@ import (
 
 // Same as upstream, except we check for GOARCH=ecmascript instead of wasm.
 // This override can be removed after https://github.com/golang/go/pull/51827
-// is available in the upstream (likely in Go 1.19).
+// is available in the upstream (likely after Go 1.19).
 func TestServerHandshakeContextCancellation(t *testing.T) {
 	c, s := localPipe(t)
 	ctx, cancel := context.WithCancel(context.Background())
@@ -42,7 +42,7 @@ func TestServerHandshakeContextCancellation(t *testing.T) {
 
 // Same as upstream, except we check for GOARCH=ecmascript instead of wasm.
 // This override can be removed after https://github.com/golang/go/pull/51827
-// is available in the upstream (likely in Go 1.19).
+// is available in the upstream (likely after Go 1.19).
 func TestClientHandshakeContextCancellation(t *testing.T) {
 	c, s := localPipe(t)
 	ctx, cancel := context.WithCancel(context.Background())
@@ -71,3 +71,15 @@ func TestClientHandshakeContextCancellation(t *testing.T) {
 		t.Error("Client connection was not closed when the context was canceled")
 	}
 }
+
+func TestVerifyConnection(t *testing.T) {
+	// This should be rechecked after upgrading to Go 1.20 or later.
+	// go1.19.13/src/crypto/tls/handshake_test.go:testRSACertificateIssuer has expired.
+	t.Skip("Skipping test that uses predefined certificate that expired in Jan 1st 2025")
+}
+
+func TestResumptionKeepsOCSPAndSCT(t *testing.T) {
+	// This should be rechecked after upgrading to Go 1.20 or later.
+	// go1.19.13/src/crypto/tls/handshake_test.go:testRSACertificateIssuer has expired.
+	t.Skip("Skipping test that uses predefined certificate that expired in Jan 1st 2025")
+}
