Updated the internalize array test to use JS

grantnelson-wf · grantnelson-wf · commit 89e8ce4f4048 · 2024-05-01T12:42:03.000-06:00
diff --git a/tests/js_test.go b/tests/js_test.go
@@ -869,24 +869,28 @@ func TestInternalizeSlice(t *testing.T) {
 }
 
 func TestInternalizeArray(t *testing.T) {
+	fn := js.Global.Call("eval", "(function(b, v) { b.V = v; })")
+
 	tests := []struct {
 		name string
-		init [3]int
+		init any
 		want string
 	}{
+		{
+			name: `null array`,
+			init: nil,
+			want: `[3]int{0, 0, 0}`,
+		},
 		{
 			name: `zeros array`,
 			init: [3]int{},
 			want: `[3]int{0, 0, 0}`,
 		},
-		// TODO(grantnelson-wf): The following test doesn't pass because
-		// the assignment of an externalized array doesn't work when this was written,
-		// see https://github.com/gopherjs/gopherjs/issues/1302
-		//{
-		//	name: `non-zero array`,
-		//	init: [3]int{42, 53, 64},
-		//	want: `[3]int{42, 53, 64}`,
-		//},
+		{
+			name: `non-zero array`,
+			init: [3]int{42, 53, 64},
+			want: `[3]int{42, 53, 64}`,
+		},
 	}
 
 	for _, tt := range tests {
@@ -895,7 +899,11 @@ func TestInternalizeArray(t *testing.T) {
 				*js.Object
 				V [3]int `js:"V"` // V is externalized
 			}{Object: js.Global.Get("Object").New()}
-			b.V = tt.init
+
+			// Assign the array to b.V using JS because of GopherJS
+			// assignment of externalized array's issue,
+			// see https://github.com/gopherjs/gopherjs/issues/1302
+			fn.Invoke(b, tt.init)
 
 			result := fmt.Sprintf(`%#v`, b.V) // internalize b.V
 			if result != tt.want {
