tests: Add failing test for internalization/externalization of time.Time/Date.

dmitshur · dmitshur · commit 99d50f05e80e · 2015-08-29T15:11:00.000-07:00
This is a test for issue #279. Proper testing for this issue prevents "testing" package from being imported. So, implement it as a low level single file .go test and invoke it from backend. In the time_inexternalization.go, you can use these statements for manual testing: var _ = time.Now() // Force time.Time not to be DCEed. var _ = time.Unix(0, 0) // Force time.Unix (and time.Time implicitly) not to be DCEed. Adding both of those statements (or just time.Unix one, since it also includes time.Time indirectly) would cause the test to pass. But a true fix will be in the compiler itself, in a way that will avoid the panics/incorrect behavior even when time.Time and/or time.Unix are DCEed, or time package is not imported at all.
diff --git a/tests/lowlevel_test.go b/tests/lowlevel_test.go
@@ -0,0 +1,31 @@
+// +build !js
+
+package tests_test
+
+import (
+	"bytes"
+	"io/ioutil"
+	"os/exec"
+	"path/filepath"
+	"testing"
+)
+
+// Test for internalization/externalization of time.Time/Date when time package is imported
+// but time.Time is unused, causing it to be DCEed (or time package not imported at all).
+//
+// See https://github.com/gopherjs/gopherjs/issues/279.
+func TestTimeInternalizationExternalization(t *testing.T) {
+	got, err := exec.Command("gopherjs", "run", filepath.Join("testdata", "time_inexternalization.go")).CombinedOutput()
+	if err != nil {
+		t.Fatalf("%v:\n%s", err, got)
+	}
+
+	want, err := ioutil.ReadFile(filepath.Join("testdata", "time_inexternalization.out"))
+	if err != nil {
+		t.Fatalf("error reading .out file: %v", err)
+	}
+
+	if !bytes.Equal(got, want) {
+		t.Fatalf("got != want:\ngot:\n%s\nwant:\n%s", got, want)
+	}
+}
diff --git a/tests/testdata/time_inexternalization.go b/tests/testdata/time_inexternalization.go
@@ -0,0 +1,19 @@
+package main
+
+import (
+	"time"
+
+	"github.com/gopherjs/gopherjs/js"
+)
+
+var _ = time.Sleep // Force "time" package to be imported but let time.Time and time.Unix be DCEed since they're not used.
+
+func main() {
+	// Excercise externalization of Go struct (with its special handling of time.Time).
+	js.Global.Get("console").Call("log", struct{ S string }{"externalization ok"})
+
+	// Excercise internalization of JavaScript Date object (with its special handling of time.Time).
+	date := js.Global.Get("Date").New("2015-08-29T20:56:00.869Z").Interface()
+	js.Global.Set("myDate", date)
+	js.Global.Get("console").Call("log", js.Global.Get("myDate").Call("toUTCString"))
+}
diff --git a/tests/testdata/time_inexternalization.out b/tests/testdata/time_inexternalization.out
@@ -0,0 +1,2 @@
+{ S: 'externalization ok' }
+Sat, 29 Aug 2015 20:56:00 GMT

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,2 @@`
	`1`	`+{ S: 'externalization ok' }`
	`2`	`+Sat, 29 Aug 2015 20:56:00 GMT`