Skip to content

Commit 9d91789

Browse files
r-l-xflimzy
authored andcommitted
regexp test: added an example use for gopherjs:keep_overridden
Before this commit, TestOnePassCutoff was skipped because a 'Maximum call stack size exceeded' message may occur. Now we use gopherjs:keep_overridden to try the original test, and skip only if the original test failed.
1 parent c47ddde commit 9d91789

File tree

1 file changed

+9
-1
lines changed

1 file changed

+9
-1
lines changed

compiler/natives/src/regexp/regexp_test.go

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,14 @@ import (
77
"testing"
88
)
99

10+
//gopherjs:keep_overridden
1011
func TestOnePassCutoff(t *testing.T) {
11-
t.Skip() // "Maximum call stack size exceeded" on V8
12+
defer func() {
13+
if r := recover(); r != nil {
14+
t.Log(r)
15+
t.Skip("'Maximum call stack size exceeded' may happen on V8, skipping")
16+
}
17+
}()
18+
19+
_gopherjs_overridden_TestOnePassCutoff(t)
1220
}

0 commit comments

Comments
 (0)