Skip to content

Commit a0dbb0e

Browse files
committed
Mark fixedbugs/issue23017.go as a known failure.
GopherJS breaks lhs expression evaluation order defined by the spec. Unfortunately, it's not easy to fix and would likely generate a lot more code for multi-assignments. An efficient fix would require writing some sort of analysis to determine if assignments are likely to influence each other, and at the moment I can't think of how such analysis would work. Without it we would have to create a whole bunch of extra temporary variables for any multi-assignment, which will likely lead to a significant increase in the artifact size. Considering nobody reported this issue so far, I'm inclined to punt on this issue for now. #1063 tracks this bug.
1 parent d60ba2c commit a0dbb0e

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

tests/gorepo/run.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -147,6 +147,7 @@ var knownFails = map[string]failReason{
147147
"fixedbugs/issue5493.go": {category: notApplicable, desc: "GC related, not relevant to GopherJS"},
148148
"fixedbugs/issue46725.go": {category: notApplicable, desc: "GC related, not relevant to GopherJS"},
149149
"fixedbugs/issue43444.go": {category: lowLevelRuntimeDifference, desc: "GopherJS println format is different from Go's"},
150+
"fixedbugs/issue23017.go": {desc: "https://github.com/gopherjs/gopherjs/issues/1063"},
150151
}
151152

152153
type failCategory uint8

0 commit comments

Comments
 (0)