Skip to content

Commit a395f9e

Browse files
committed
CI: Prefer --minify flag for all tests.
This largely reverts commit b9c0354. It was originally done for convenience, to improve readability of stack traces during failures. However, it's more important to prioritize doing test coverage of the same build mode as used in production (minification on). That's a sufficient reason to keep the --minify flag for gopherjs test of all packages.
1 parent 853e795 commit a395f9e

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

circle.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ test:
2020
- diff -u <(echo -n) <(go list ./compiler/natives/src/...) # All those packages should have // +build js.
2121
- gopherjs install -v net/http # Should build successfully (can't run tests, since only client is supported).
2222
- >
23-
gopherjs test -v --short
23+
gopherjs test --minify -v --short
2424
github.com/gopherjs/gopherjs/tests
2525
github.com/gopherjs/gopherjs/tests/main
2626
github.com/gopherjs/gopherjs/js
@@ -131,4 +131,4 @@ test:
131131
unicode/utf16
132132
unicode/utf8
133133
- go test -v -race ./...
134-
- gopherjs test -v --minify fmt # Minification should work.
134+
- gopherjs test -v fmt # No minification should work.

0 commit comments

Comments
 (0)