Merge pull request #1297 from Workiva/moreKnownFails

nevkontakte · web-flow · commit bce1d3f0ab0f · 2024-04-30T21:02:12.000+01:00
[go1.20] More known fails and a fix
diff --git a/compiler/linkname_test.go b/compiler/linkname_test.go
@@ -190,8 +190,8 @@ func TestParseGoLinknames(t *testing.T) {
 			`,
 			wantDirectives: []GoLinkname{
 				{
-					Reference:      SymName{PkgPath: `testcase`, Name: `a`},
-					Implementation: SymName{PkgPath: `other/package`, Name: `b.a`},
+					Reference:      symbol.Name{PkgPath: `testcase`, Name: `a`},
+					Implementation: symbol.Name{PkgPath: `other/package`, Name: `b.a`},
 				},
 			},
 		}, {
@@ -206,8 +206,8 @@ func TestParseGoLinknames(t *testing.T) {
 			`,
 			wantDirectives: []GoLinkname{
 				{
-					Reference:      SymName{PkgPath: `testcase`, Name: `a`},
-					Implementation: SymName{PkgPath: `other/package`, Name: `*b.a`},
+					Reference:      symbol.Name{PkgPath: `testcase`, Name: `a`},
+					Implementation: symbol.Name{PkgPath: `other/package`, Name: `*b.a`},
 				},
 			},
 		},
diff --git a/tests/gorepo/run.go b/tests/gorepo/run.go
@@ -151,6 +151,9 @@ var knownFails = map[string]failReason{
 	// These are new tests in Go 1.20
 	"fixedbugs/issue25897a.go": {category: neverTerminates, desc: "does for { runtime.GC() }"},
 	"fixedbugs/issue54343.go":  {category: notApplicable, desc: "uses runtime.SetFinalizer() and runtime.GC()."},
+	"fixedbugs/issue57823.go":  {category: notApplicable, desc: "uses runtime.SetFinalizer() and runtime.GC()."},
+	"fixedbugs/issue59293.go":  {category: usesUnsupportedPackage, desc: "uses unsafe.SliceData() and unsafe.StringData()."},
+	"fixedbugs/issue43942.go":  {category: other, desc: "https://github.com/gopherjs/gopherjs/issues/1126"},
 }
 
 type failCategory uint8

Original file line number	Diff line number	Diff line change
`@@ -151,6 +151,9 @@ var knownFails = map[string]failReason{`
`151`	`151`	`// These are new tests in Go 1.20`
`152`	`152`	`"fixedbugs/issue25897a.go": {category: neverTerminates, desc: "does for { runtime.GC() }"},`
`153`	`153`	`"fixedbugs/issue54343.go": {category: notApplicable, desc: "uses runtime.SetFinalizer() and runtime.GC()."},`
	`154`	`+ "fixedbugs/issue57823.go": {category: notApplicable, desc: "uses runtime.SetFinalizer() and runtime.GC()."},`
	`155`	`+ "fixedbugs/issue59293.go": {category: usesUnsupportedPackage, desc: "uses unsafe.SliceData() and unsafe.StringData()."},`
	`156`	`+ "fixedbugs/issue43942.go": {category: other, desc: "https://github.com/gopherjs/gopherjs/issues/1126"},`
`154`	`157`	`}`
`155`	`158`
`156`	`159`	`type failCategory uint8`