Skip to content

Commit bed99a8

Browse files
authored
CI: fix breakage and update minor Go version
The latest version of node-gyp (v7.1.2 at this time) is not compatible with Node v10.0.0 that circle.yml installs. Go back to a known working version of node-gyp to get a working CI. Update the CI script to test against Go 1.12.17¹, the latest minor release in the Go 1.12.x series. ¹ https://golang.org/doc/devel/release.html#go1.12.minor Updates #894. Fixes #987. GitHub-Pull-Request: #988
1 parent fce0ec3 commit bed99a8

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

circle.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,12 +11,12 @@ jobs:
1111
- checkout
1212
- run: git clone https://github.com/creationix/nvm $HOME/.nvm && cd $HOME/.nvm && git checkout v0.33.9 && echo 'export NVM_DIR="$HOME/.nvm"' >> $BASH_ENV && echo '[ -s "$NVM_DIR/nvm.sh" ] && \. "$NVM_DIR/nvm.sh"' >> $BASH_ENV
1313
- run: nvm install 10.0.0 && nvm alias default 10.0.0
14-
- run: cd /usr/local && sudo rm -rf go && curl https://storage.googleapis.com/golang/go1.12.16.linux-amd64.tar.gz | sudo tar -xz
14+
- run: cd /usr/local && sudo rm -rf go && curl https://storage.googleapis.com/golang/go1.12.17.linux-amd64.tar.gz | sudo tar -xz
1515
- run: echo 'export PATH="$PATH:/usr/local/go/bin:$HOME/go/bin"' >> $BASH_ENV
1616
- run: go get -t -d -v ./...
1717
- run: go install -v
1818
- run: npm install # Install our (dev) dependencies from package.json.
19-
- run: npm install --global node-gyp
19+
- run: npm install --global node-gyp@5.1.1
2020
- run: cd node-syscall && node-gyp rebuild && mkdir -p ~/.node_libraries && cp build/Release/syscall.node ~/.node_libraries/syscall.node
2121

2222
- run: go generate github.com/gopherjs/gopherjs/compiler/prelude

0 commit comments

Comments
 (0)