compiler/natives/src/math/big: Remove bitLen, override Word.

dmitshur · dmitshur · commit c8a99bbfe87b · 2017-08-25T14:19:47.000-04:00
math/big package no longer has a bitLen low-level function, so it can be removed. In Go 1.9, the type of big.Word has changed from uintptr to uint. Due to issue #652 with uint multiplication with overflows, we use a workaround of overriding type of Word back to uintptr. This should be undone once #652 is fixed. Fixes: $ gopherjs test --short math/big $GOROOT/src/math/big/big.go:39:9: undeclared name: bitLen_g
diff --git a/compiler/natives/src/math/big/big.go b/compiler/natives/src/math/big/big.go
@@ -2,6 +2,13 @@
 
 package big
 
+// TODO: This is a workaround for https://github.com/gopherjs/gopherjs/issues/652.
+//       Remove after that issue is resolved.
+type Word uintptr
+
+// TODO: Consider using math_big_pure_go build tag for this package, instead of
+//       defining all these pure Go low level operators ourselves.
+
 func mulWW(x, y Word) (z1, z0 Word) {
 	return mulWW_g(x, y)
 }
@@ -35,6 +42,3 @@ func addMulVVW(z, x []Word, y Word) (c Word) {
 func divWVW(z []Word, xn Word, x []Word, y Word) (r Word) {
 	return divWVW_g(z, xn, x, y)
 }
-func bitLen(x Word) (n int) {
-	return bitLen_g(x)
-}
