compiler/natives/src/crypto/x509: Update package and tests for Go 1.9.

dmitshur · dmitshur · commit e39dba420d95 · 2017-08-25T14:19:47.000-04:00
Skip new Go 1.9 Linux-only test TestEnvVars that depends on system
roots, which GopherJS doesn't support. This is quite okay, as they're
not supported on Windows either:

	func SystemCertPool() (*CertPool, error) {
		if runtime.GOOS == "windows" {
			// Issue 16736, 18609:
			return nil, errors.New("crypto/x509: system root pool is not available on Windows")
		}

		return loadSystemRoots()
	}

Return non-nil error in loadSystemRoots so that x509.SystemCertPool
correctly reports a failure. As a result, need to skip
TestSystemCertPool now too.

There's no need to override execSecurityRoots, because nothing needs or
calls it (the things that do are overridden or skipped).
diff --git a/compiler/natives/src/crypto/x509/x509.go b/compiler/natives/src/crypto/x509/x509.go
@@ -2,13 +2,8 @@
 
 package x509
 
-import "os"
+import "errors"
 
 func loadSystemRoots() (*CertPool, error) {
-	// no system roots
-	return NewCertPool(), nil
-}
-
-func execSecurityRoots() (*CertPool, error) {
-	return nil, os.ErrNotExist
+	return nil, errors.New("crypto/x509: system root pool is not available in GopherJS")
 }
diff --git a/compiler/natives/src/crypto/x509/x509_test.go b/compiler/natives/src/crypto/x509/x509_test.go
@@ -4,10 +4,18 @@ package x509
 
 import "testing"
 
+func TestSystemCertPool(t *testing.T) {
+	t.Skip("no system roots")
+}
+
 func TestSystemRoots(t *testing.T) {
 	t.Skip("no system roots")
 }
 
+func TestEnvVars(t *testing.T) {
+	t.Skip("no system roots")
+}
+
 func TestSystemVerify(t *testing.T) {
 	t.Skip("no system")
 }
