Fix possible panic during internalization/externalization of time.Time/Date.

dmitshur · dmitshur · commit f76722538d3e · 2015-08-30T13:47:03.000-07:00
Fixes #279 (initial report). The internalization/externalization code only checks if the time package is present and assumes time.Unix and time.Time are available if so. Previously, it was possible for time package to be present, but either time.Unix or time.Time were not (due to dead code elimination), causing possible panics. In time package itself, ensure time.Unix func and time.Time struct it returns are always included (despite DCE) to prevent that from happening.
diff --git a/compiler/natives/time/time.go b/compiler/natives/time/time.go
@@ -9,6 +9,13 @@ import (
 	"github.com/gopherjs/gopherjs/js"
 )
 
+// Make sure time.Unix func and time.Time struct it returns are always included with this package (despite DCE),
+// because they're needed for internalization/externalization of time.Time/Date. See issue https://github.com/gopherjs/gopherjs/issues/279.
+func init() {
+	// avoid dead code elimination
+	var _ Time = Unix(0, 0)
+}
+
 type runtimeTimer struct {
 	i       int32
 	when    int64
