Skip to content

Commit fcc469a

Browse files
committed
tests/lowlevel_test.go: Only compare stdout, ignore stderr.
The goal of the test is to compare stdout to make sure it equals to what is expected. Ignore stderr as there may be unrelated warnings there, for example the warning that GopherJS prints when source map support module is not installed. Fixes the following invalid test failure: go test -run=TestTimeInternalizationExternalization github.com/gopherjs/gopherjs/tests --- FAIL: TestTimeInternalizationExternalization (0.30s) lowlevel_test.go:29: got != want: got: gopherjs: Source maps disabled. Use Node.js 4.x with source-map-support module for nice stack traces. { S: 'externalization ok' } Sat, 29 Aug 2015 20:56:00 GMT want: { S: 'externalization ok' } Sat, 29 Aug 2015 20:56:00 GMT FAIL FAIL github.com/gopherjs/gopherjs/tests 0.313s
1 parent 700220d commit fcc469a

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

tests/lowlevel_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ import (
1515
//
1616
// See https://github.com/gopherjs/gopherjs/issues/279.
1717
func TestTimeInternalizationExternalization(t *testing.T) {
18-
got, err := exec.Command("gopherjs", "run", filepath.Join("testdata", "time_inexternalization.go")).CombinedOutput()
18+
got, err := exec.Command("gopherjs", "run", filepath.Join("testdata", "time_inexternalization.go")).Output()
1919
if err != nil {
2020
t.Fatalf("%v:\n%s", err, got)
2121
}

0 commit comments

Comments
 (0)