-
Notifications
You must be signed in to change notification settings - Fork 570
gopherjs get: Does not work reliably. #270
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Would it be an option to simply have 'gopherjs get' execute 'go get -d tags=js'? The only advantage, of course, is that 'gopherjs get' is easier to remember. |
Yes, that's the alternative 1 that I mentioned:
|
For me, it's easier to remember Having to remember what |
|
I see. That should indeed fix the main problem I've reported, but what about the additional ones, like:
|
We can also pass those through to the |
I see no reason to remove it, it's just a few lines of code, nothing fancy. If someone needs more flags, then it's probably best to just fall back to the separate commands. Do you think we need to make this option more obvious? |
I think the help/usage string for |
For example:
On the other hand, using
go get
withjs
build tag works:Additionally,
gopherjs get
is missing-u
flag and some others.Proposed Solutions
The logic of
go get
is quite complicated, and it tends to move forward with each point release of Go.I see clear value to have
gopherjs build
,gopherjs install
that mimic those commands ofgo
tool.gopherjs serve
is also extremely useful. In constrast,gopherjs get
seems completely unneeded because you can always usego get
with-d
and-tags=js
, followed bygophers install
to simulate whatgopherjs get
is expected to achieve:# gopherjs get import/path go get -d -tags=js import/path gopherjs install import/path
At this time, I think the best solution to this issue is to remove
gopherjs get
command. It will mean less maintenance and I think it's simpler for users.Alternatives are:
gopherjs get
work more reliably by shelling out togo get
(should be quite easy).The text was updated successfully, but these errors were encountered: