Skip to content

review nit #753

Open
Open
@glycerine

Description

@glycerine

fields.forEach(function(f) {
if (!f.typ.comparable) {
typ.comparable = false;
}
});

      fields.forEach(function(f) {
        if (!f.typ.comparable) {
          typ.comparable = false;
        }
      });

nit: one can break out of the loop as soon as a non-comparable is found,

for (var i = 0, len = fields.length; i < len; i++) {
   if (!fields[i].typ.comparable) {
          typ.comparable = false;
          break;
        }
}

Metadata

Metadata

Assignees

No one assigned

    Labels

    NeedsHelpCommunity contributions are welcome for this feature!enhancement

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions