You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
First and foremost: thank you for this awesome piece of software! I've encountered a bug in which gopherjs handles interface calls on non-pointer receiver structs. It seems (to me) quiet severe but I couldn't find any bug that reported this. I'm on Go 1.10 and GopherJS 1.10-2.
When running this playground: https://play.golang.org/p/sIjx8DQWMpO. We see that struct fields modified in methods that do not have a pointer receiver indeed have no effect:
A long time ago I pushed up #669 in order to address this; apologies, dropped the ball on getting it merged. I'll see that through now, but in the meantime perhaps you could verify whether it's the same issue and confirm that my PR addresses things from your perspective?
Uh oh!
There was an error while loading. Please reload this page.
Hey everyone!
First and foremost: thank you for this awesome piece of software! I've encountered a bug in which gopherjs handles interface calls on non-pointer receiver structs. It seems (to me) quiet severe but I couldn't find any bug that reported this. I'm on Go 1.10 and GopherJS 1.10-2.
When running this playground: https://play.golang.org/p/sIjx8DQWMpO. We see that struct fields modified in methods that do not have a pointer receiver indeed have no effect:
Running the same code using gopherjs https://gopherjs.github.io/playground/#/0pktxkdKEX will yield a different result: the modification to the non-pointer receiver is effective outside the call:
The text was updated successfully, but these errors were encountered: