Skip to content

test: explore re-enabling tests previously skipped because of stack size #801

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
myitcv opened this issue Apr 21, 2018 · 0 comments
Open

test: explore re-enabling tests previously skipped because of stack size #801

myitcv opened this issue Apr 21, 2018 · 0 comments
Labels
NeedsHelp Community contributions are welcome for this feature! NeedsInvestigation

Comments

@myitcv
Copy link
Member

myitcv commented Apr 21, 2018

Per #798 (comment):

And actually both on my configuration and on circleci the test runs well (so it seems like it could be re-enabled):

=== RUN   TestOnePassCutoff
--- PASS: TestOnePassCutoff (0.08s)

"It" here is a reference to regexp's TestOnePassCutoff which is skipped on the basis it has in the past exceed the call stack size.

Following #687, stack size issues should be greatly reduced and/or have disappeared entirely.

Hence we should now review whether tests like regexp's TestOnePassCutoff can be re-enabled.
@myitcv myitcv mentioned this issue Apr 21, 2018
Closed
@flimzy flimzy added NeedsHelp Community contributions are welcome for this feature! NeedsInvestigation labels Apr 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
NeedsHelp Community contributions are welcome for this feature! NeedsInvestigation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@myitcv @flimzy