Wouldn't this break compatibility with go?

Hi @flimzy ,

I can't say for sure, as I'm not knowledgeable of the internals of either GopherJS, Vgo toolchain, or Go toolchain.

But what I can say is that, from a practical perspective, it seems that the VGo binary behaves exactly like the Go binary in "normal" Golang codebases (ie, with a "traditional" GOPATH). To "activate" the special features, you have to create a file called go.mod.

So I would assume that it wouldn't break compatibility - VGo is intended to be released as part of Go 1.11, AFAIK. If they don't break the "promise of compatibility", it should be compatible.

Cheers!
Bruno

@bfreis @flimzy - this should be possible. At the moment GopherJS uses go/build for package discovery; this will need to be replaced by something like the planned go/packages.

If this is slated for inclusion in Go 1.11, doesn't it make sense for GopherJS to wait until Go 1.11, as well?

I'd be very concerned about projects that work with both Go and GopherJS, being treated differently in the two environments. In this sense, retaining backward compatibility isn't the only compatibility concern.

If this is slated for inclusion in Go 1.11, doesn't it make sense for GopherJS to wait until Go 1.11, as well?

Sorry, yes, agreed - that was implicit in my answer. Arguably we could/should wait for an initial cut of go/packages to land first too (although that's not strictly necessary, might just save us some work).

Just an FYI on this issue, I am working on vgo support for GopherJS, support that will be in-line with the experimental release of vgo within Go 1.11.

This will initially be be merged into https://github.com/myitcv/gopherjs.

I will also raise a PR against this repo, but I know @shurcooL has a lot on at the moment.

@myitcv any updates on this?

@Gee5ive https://github.com/myitcv/gopherjs/tree/go1.11 is being actively maintained.

It has Go 1.11 support, almost complete support for modules, as well as the changes from the following PRs that are still open in this main repo:

• vendor: vendor go/types to workaround bug in method set calc.
• compiler: fix variadic args not being nil when zero length
• compiler: use hash calculation for determining archive staleness
• ci: upgrade to CircleCI 2
• compiler/prelude: format .js files using prettier
• compiler/prelude: move prelude to separate .js files
• js: add MakeFullWrapper to expose exported methods and struct fields

@Gee5ive (and others) I've just merged the changes in the go1.11 branch of https://github.com/myitcv/gopherjs into master (of that fork) and created a go1.10 branch for posterity.

I'm closing this in favor of #855, which is an effective duplicate, after modules have been made official.