-
Notifications
You must be signed in to change notification settings - Fork 570
Go 1.13 support #929
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
We are already testing Go 1.13 in Fedora, and the latest build for F31 failed because of this. |
I've created the |
I've pushed one commit to Next up we'll need deal with https://tip.golang.org/pkg/internal/reflectlite/
We'll need to find a way to implement it or find a way to make it not required by other packages. I tried two approaches unsuccessfully so far:
Stopping here for now, just wanted to post an update about some progress made. Others are welcome to pick it up from here if you have the bandwidth. |
Any ETA on this? |
Bump. |
FWIW I have an 80% working 1.13 branch at myitcv#50 Tests are currently the only known outstanding item. i.e. |
@myitcv I did some tests with my app against wasm. Unfortunately as of now without significant optimization work, wasm will quickly run out of memory and consumes a ton of CPU I know that this will improve with work to the Go compiler as well as new features / design aspects being ironed out in WebAssembly. But it also seems to be a bit /too/ alpha to use for even a moderately critical application, while the JavaScript approach seems like it will work well in a lot of environments for quite some time to come. For that reason I think the Go to Js approach will be useful and viable for a long time. Thank you for your work towards go1.13, I will test it and let you know if I find any quirks. |
Hi @myitcv, I'm interested in making 1.13 support happen sooner. Anything in particular I could help with? :) |
@myitcv There's currently over 1200 lines of code hidden in your branch in the "tool.go" and similar files in the root of the gopherjs repository. That code is not accessible by my code importing the "gopherjs/build" pakages directly. Would it be possible to move that common code used to generate the arguments for NewSession() (including imports) to a package where I can access it externally? |
@nevkontakte - if you're happy to jump in and start fixing things up on myitcv#50 then please do, just give me a heads up on what you're planning to work on. Otherwise I will get to doing bits and pieces as and when I can. Verifying your applications work with that branch is probably one of the biggest helps, save the fact that @paralin following on from our conversation in #855, my primary focus has been on a minimal working solution. I think we can look to "fix" the API of |
@myitcv No worries, I was just posting a comment about it to keep it in the discussion. I can always modify the code myself in the meantime anyway. I appreciate the work & will keep testing the CLI version for now. |
Thanks @myitcv, I'll see what I can help with. I'll continue with my questions on your PR if you don't mind. |
I got an error when compiling go code to js. My code structure is like: //main.go to compile to js //abc.go When compile, gopherjs output: My Go version is 1.13.5 and gopherjs version is 1.13-3, running on MacOS 10.15.1. I am new to GopherJS and there could be something I missed to encounter this problem, and I spent hours to track it down. Pls anyone help me out. |
Go 1.13 is not supported yet. |
Any updates? |
Just FYI, this should not be necessary any longer. You can now run GopherJS 1.12 with Go 1.13. This is what I've been doing. You'll need to follow the updated installation instructions. |
Fixed with #1015 |
The season will come soon :)
The text was updated successfully, but these errors were encountered: