Update NodeJS from 12 to 18 #1329
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Instead of breaking into ArrayBuffer underlying memory via a hard-coded offset, we allocate a data buffer in the arena and copy data out using public API. - Update module initializer function to not generate any complier warnings. - Fix a bug in the arena which returned an invalid pointer. I have no idea how this worked before. `allocs_.end()` returned an iterator pointing to *after* the last element, which is invalid memory. So we've been previous copying data who knows where and nobody noticed.
NodeJS 12 has been end-of-life since 2022-04-30, and 18 is the current oldest supported LTS version, which will be supported until 2025-04-30. I also update npm dependencies to the modern versions.
The example relies on the local HTTP server, which is not fully supported by GopherJS. Node 18 provides global Fetch API, so the net/http package no longer falls back onto fake networking automatically.
flimzy
approved these changes
Jul 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NodeJS 12 has been end-of-life since 2022-04-30, so there's not much value in testing against it. 18 is the current oldest supported LTS version, so we use that in CI. I also had to make a few minor updates to the
node_syscallextension to make sure it continues working.