ci: upgrade to CircleCI 2 #797
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f1eba16 to
9c1cdea
Compare
62411e6 to
1e1ddc5
Compare
c4a4a3f to
e2d96d9
Compare
myitcv
commented
Apr 20, 2018
| os/exec | ||
| os/signal | ||
| os/signal/internal/pty | ||
| os/user |
There was a problem hiding this comment.
We add os/user to this exclusion list.
e2d96d9 to
32b3d01
Compare
32b3d01 to
5754c1f
Compare
|
@shurcooL @hajimehoshi this is ready for review. |
ac6f9f6 to
856b94a
Compare
856b94a to
6dc3172
Compare
6dc3172 to
d50dc88
Compare
dmitshur
added a commit
that referenced
this pull request
Oct 4, 2018
This is a minimal diff change to upgrade from CircleCI 1.0 to 2.0 and get it working, since 1.0 has been EOLed. The goal was to keep the config.yml file as simple as possible for now; we can consider changes and enhancements to it as part of future work. Remove os/user package from being tested, since it's failing in the CircleCI 2.0 environment (see tracking issue #863). Resolves #766. Updates #797.
|
Closing because this was superseded by #864 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on the instructions https://circleci.com/docs/2.0/migrating-from-1-2/, this is as straightforward an upgrade as possible, i.e. with as few variations as possible.
We also move to an exclusion list approach for the standard library tests we want to ignore. This is an entirely derived list based on the current exclusions with the exception of
os/userwhich is added in order to make the tests pass. Further work can be done on this exclusion list in future PRs (i.e. removing exclusions that should not be there).Fixes #766.