update.sh: quote all relevant variable uses

dominikh · dominikh · commit 29f4fefc84ec · 2016-02-22T02:45:26.000+01:00
Even quote the use of PKG. While not necessary right now, it protects us
from future code breakage.
diff --git a/playground/update.sh b/playground/update.sh
@@ -23,22 +23,22 @@ gopherjs build -m
 GOPHERJSGOPATH=$(go list -f '{{.Root}}' github.com/gopherjs/gopherjs)
 
 PKG=pkg
-rm -r $PKG
+rm -r "$PKG"
 
 # Use an empty GOPATH workspace with just gopherjs,
 # so that all the standard library packages get written to GOROOT/pkg.
 export GOPATH="$tmp_gopath"
-mkdir -p $GOPATH/src/github.com/gopherjs/gopherjs
-cp -a $GOPHERJSGOPATH/src/github.com/gopherjs/gopherjs/* $GOPATH/src/github.com/gopherjs/gopherjs
+mkdir -p "$GOPATH"/src/github.com/gopherjs/gopherjs
+cp -a "$GOPHERJSGOPATH"/src/github.com/gopherjs/gopherjs/* "$GOPATH"/src/github.com/gopherjs/gopherjs
 
 gopherjs install -m github.com/gopherjs/gopherjs/js github.com/gopherjs/gopherjs/nosync
-mkdir -p $PKG/github.com/gopherjs/gopherjs
-cp $GOPATH/pkg/*_js_min/github.com/gopherjs/gopherjs/js.a $PKG/github.com/gopherjs/gopherjs/js.a
-cp $GOPATH/pkg/*_js_min/github.com/gopherjs/gopherjs/nosync.a $PKG/github.com/gopherjs/gopherjs/nosync.a
+mkdir -p "$PKG"/github.com/gopherjs/gopherjs
+cp "$GOPATH"/pkg/*_js_min/github.com/gopherjs/gopherjs/js.a "$PKG"/github.com/gopherjs/gopherjs/js.a
+cp "$GOPATH"/pkg/*_js_min/github.com/gopherjs/gopherjs/nosync.a "$PKG"/github.com/gopherjs/gopherjs/nosync.a
 
 # Make a copy of GOROOT that is user-writeable,
 # use it to build and copy out standard library packages.
-cp -a $(go env GOROOT)/. "$tmp_goroot"
+cp -a "$(go env GOROOT)" "$tmp_goroot"
 export GOROOT="$tmp_goroot"
 gopherjs install -m \
          archive/tar \
@@ -139,8 +139,8 @@ gopherjs install -m \
          unicode/utf16 \
          unicode/utf8
 
-cp -a $GOROOT/pkg/*_js_min/* $PKG
-cp -a $GOROOT/pkg/*_amd64_js_min/* $PKG
+cp -a "$GOROOT"/pkg/*_js_min/* $PKG
+cp -a "$GOROOT"/pkg/*_amd64_js_min/* $PKG
 
 # Rename all *.a files in $PKG to *.a.js.
 find "$PKG" -name "*.a" -exec sh -c 'mv $0 $0.js' {} \;
