-
-
Notifications
You must be signed in to change notification settings - Fork 5
feat: migrate package to ESM #154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
BREAKING CHANGE: package is now ESM BREAKING CHANGE: Require Node JS v21.2.0, v20.11.0 or greater for import.meta.dirname
🤦🏼 sorry I missed that your PR is still a draft |
The snapshot changes might be legit. |
ah nevermind, I got the snapshot diff the wrong way around, the tests are failing because the snapshots are |
I'll try to extract some changes from this PR to try and isolate the specific changes that lead to the error |
It seems that using |
This is now ready! 🚀 |
most likely a difference between |
That was indeed the case, |
🎉 This PR is included in version 5.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
BREAKING CHANGE: package is now ESM
BREAKING CHANGE: Require Node JS >= 18
Fixes #132