Skip to content

Conversation

wolfy1339
Copy link
Collaborator

@wolfy1339 wolfy1339 commented Apr 10, 2025

BREAKING CHANGE: package is now ESM
BREAKING CHANGE: Require Node JS >= 18

Fixes #132

BREAKING CHANGE: package is now ESM
BREAKING CHANGE: Require Node JS v21.2.0, v20.11.0 or greater for import.meta.dirname
@gr2m
Copy link
Owner

gr2m commented Apr 10, 2025

Any idea why tests are failing?

🤦🏼 sorry I missed that your PR is still a draft

@gr2m
Copy link
Owner

gr2m commented Apr 20, 2025

The snapshot changes might be legit. enpoint: null does not look like what we want in these tests

@gr2m
Copy link
Owner

gr2m commented Apr 20, 2025

The snapshot changes might be legit. enpoint: null does not look like what we want in these tests

ah nevermind, I got the snapshot diff the wrong way around, the tests are failing because the snapshots are endpoint: null now, with the changes in this PR

@wolfy1339
Copy link
Collaborator Author

I'll try to extract some changes from this PR to try and isolate the specific changes that lead to the error

@wolfy1339
Copy link
Collaborator Author

wolfy1339 commented Apr 20, 2025

It seems that using lodash-es, sticking to got instead of fetch, using default imports for semver fixed the test failures

@wolfy1339 wolfy1339 marked this pull request as ready for review April 20, 2025 23:45
@wolfy1339
Copy link
Collaborator Author

This is now ready! 🚀

@gr2m
Copy link
Owner

gr2m commented Apr 21, 2025

most likely a difference between fetch and got. But one problem at a time, great work, thank you @wolfy1339!

@wolfy1339
Copy link
Collaborator Author

most likely a difference between fetch and got. But one problem at a time, great work, thank you @wolfy1339!

That was indeed the case, headers returned by fetch isn't a simple object, it's a Headers class object, which made the check for the link header fail.
5243c7b

@wolfy1339 wolfy1339 merged commit 2f92cd5 into gr2m:main Apr 21, 2025
2 checks passed
Copy link

🎉 This PR is included in version 5.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Problem running in ESM module
2 participants