Feedback on adding nullability annotations #3630
Replies: 1 comment 2 replies
-
|
yeah we under estimated the "breaking change ness" of this PR. An external contributor wanted to add an extra "improvement" on the non nullability of key methods in DataFetcherEnvironment They were always non null in effect but not indicated as such. We don't have extensive coverage on annotations (although we have increased the use of them over time) So this betterness change ends up breaking Kotlin compilation. We will be more deligent in the future on this kinda of change. |
Beta Was this translation helpful? Give feedback.
-
|
I'll edit the release notes to highlight this, thanks @paulbakker |
Beta Was this translation helpful? Give feedback.
-
|
Thanks for the replies! |
Beta Was this translation helpful? Give feedback.
Uh oh!
There was an error while loading. Please reload this page.
-
Hi folks, just some learnings from upgrading to GraphQL Java 22.
Nullability annotations were added to several methods. While this looks like a small change (and a good one), we did see issues caused by this. I'm just bringing this up to keep in mind in the future, and it doesn't mean such changes shouldn't be made.
Builds started failing because of the new nullability in two scenarios:
Because of the failing builds, it's sort of a breaking change, but probably not considered that way.
Again, not a big deal, just something to be aware of.
Beta Was this translation helpful? Give feedback.
All reactions