Skip to content

Tracking spec change: non-nullable reason for @deprecated #3736

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
dondonz opened this issue Oct 29, 2024 · 0 comments · Fixed by #3759
Closed

Tracking spec change: non-nullable reason for @deprecated #3736

dondonz opened this issue Oct 29, 2024 · 0 comments · Fixed by #3759
Labels
spec-change Tracking GraphQL specification changes

Comments

@dondonz
Copy link
Member

dondonz commented Oct 29, 2024

Keeping a note here for us to return to later, this small spec change may get merged in soon graphql/graphql-spec#1040

It changes @deprecated's reason to be non-nullable. There's a default value for the reason already, so the migration pathway isn't a big deal, it's more about removing an odd edge case.

This is not yet in the spec, this issue is a reminder to check in on this topic again later
@dondonz dondonz added the keep-open Tells Stale Bot to keep PRs and issues open label Nov 14, 2024
@dondonz dondonz changed the title Incoming minor spec change to @deprecated Tracking spec change: non-nullable reason for @deprecated Nov 24, 2024
@dondonz dondonz added spec-change Tracking GraphQL specification changes and removed keep-open Tells Stale Bot to keep PRs and issues open labels Nov 24, 2024
@dondonz dondonz mentioned this issue Dec 1, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
spec-change Tracking GraphQL specification changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make deprecated reason non-null graphql-java/graphql-java
1 participant
@dondonz