chore add unit test for role sync

Emyrk · Emyrk · commit 6225ddf92bec · 2024-09-17T11:29:06.000-05:00
diff --git a/cli/organizationsettings.go b/cli/organizationsettings.go
@@ -69,8 +69,12 @@ func (r *RootCmd) updateOrganizationSetting(orgContext *OrganizationContext) *se
 				}
 				setting, err = client.PatchGroupIDPSyncSettings(ctx, org.ID.String(), req)
 			case "rolesync", "role-sync":
-				// TODO: Implement role sync settings.
-				return fmt.Errorf("role sync settings are not implemented")
+				var req codersdk.RoleSyncSettings
+				err = json.Unmarshal(inputData, &req)
+				if err != nil {
+					return xerrors.Errorf("unmarshalling role sync settings: %w", err)
+				}
+				setting, err = client.PatchRoleIDPSyncSettings(ctx, org.ID.String(), req)
 			default:
 				_, _ = fmt.Fprintln(inv.Stderr, "Valid organization settings are: 'groupsync', 'rolesync'")
 				return fmt.Errorf("unknown organization setting %s", inv.Args[0])
@@ -126,8 +130,7 @@ func (r *RootCmd) printOrganizationSetting(orgContext *OrganizationContext) *ser
 			case "groupsync", "group-sync":
 				setting, err = client.GroupIDPSyncSettings(ctx, org.ID.String())
 			case "rolesync", "role-sync":
-				// TODO: Implement role sync settings.
-				return fmt.Errorf("role sync settings are not implemented")
+				setting, err = client.RoleIDPSyncSettings(ctx, org.ID.String())
 			default:
 				_, _ = fmt.Fprintln(inv.Stderr, "Valid organization settings are: 'groupsync', 'rolesync'")
 				return fmt.Errorf("unknown organization setting %s", inv.Args[0])
diff --git a/enterprise/cli/organizationsettings_test.go b/enterprise/cli/organizationsettings_test.go
@@ -11,6 +11,7 @@ import (
 
 	"github.com/coder/coder/v2/cli/clitest"
 	"github.com/coder/coder/v2/coderd/coderdtest"
+	"github.com/coder/coder/v2/coderd/rbac"
 	"github.com/coder/coder/v2/codersdk"
 	"github.com/coder/coder/v2/enterprise/coderd/coderdenttest"
 	"github.com/coder/coder/v2/enterprise/coderd/license"
@@ -69,3 +70,53 @@ func TestUpdateGroupSync(t *testing.T) {
 		require.JSONEq(t, string(expectedData), buf.String())
 	})
 }
+
+func TestUpdateRoleSync(t *testing.T) {
+	t.Parallel()
+
+	t.Run("OK", func(t *testing.T) {
+		dv := coderdtest.DeploymentValues(t)
+		dv.Experiments = []string{string(codersdk.ExperimentMultiOrganization)}
+
+		owner, _ := coderdenttest.New(t, &coderdenttest.Options{
+			Options: &coderdtest.Options{
+				DeploymentValues: dv,
+			},
+			LicenseOptions: &coderdenttest.LicenseOptions{
+				Features: license.Features{
+					codersdk.FeatureMultipleOrganizations: 1,
+				},
+			},
+		})
+
+		ctx := testutil.Context(t, testutil.WaitLong)
+		inv, root := clitest.New(t, "organization", "settings", "set", "rolesync")
+		clitest.SetupConfig(t, owner, root)
+
+		expectedSettings := codersdk.RoleSyncSettings{
+			Field: "roles",
+			Mapping: map[string][]string{
+				"test": {rbac.RoleOrgAdmin()},
+			},
+		}
+		expectedData, err := json.Marshal(expectedSettings)
+		require.NoError(t, err)
+
+		buf := new(bytes.Buffer)
+		inv.Stdout = buf
+		inv.Stdin = bytes.NewBuffer(expectedData)
+		err = inv.WithContext(ctx).Run()
+		require.NoError(t, err)
+		require.JSONEq(t, string(expectedData), buf.String())
+
+		// Now read it back
+		inv, root = clitest.New(t, "organization", "settings", "show", "rolesync")
+		clitest.SetupConfig(t, owner, root)
+
+		buf = new(bytes.Buffer)
+		inv.Stdout = buf
+		err = inv.WithContext(ctx).Run()
+		require.NoError(t, err)
+		require.JSONEq(t, string(expectedData), buf.String())
+	})
+}
