fix(site): fix tooltip in start button group (coder#13497)

BrunoQuaresma · web-flow · commit a8a81a61cdc1 · 2024-06-06T14:51:52.000-03:00
diff --git a/site/src/pages/WorkspacePage/WorkspaceActions/Buttons.tsx b/site/src/pages/WorkspacePage/WorkspaceActions/Buttons.tsx
@@ -63,7 +63,21 @@ export const StartButton: FC<ActionButtonPropsWithWorkspace> = ({
   disabled,
   tooltipText,
 }) => {
-  const buttonContent = (
+  let mainButton = (
+    <TopbarButton
+      startIcon={<PlayCircleOutlineIcon />}
+      onClick={() => handleAction()}
+      disabled={disabled || loading}
+    >
+      {loading ? <>Starting&hellip;</> : "Start"}
+    </TopbarButton>
+  );
+
+  if (tooltipText) {
+    mainButton = <Tooltip title={tooltipText}>{mainButton}</Tooltip>;
+  }
+
+  return (
     <ButtonGroup
       variant="outlined"
       sx={{
@@ -74,13 +88,7 @@ export const StartButton: FC<ActionButtonPropsWithWorkspace> = ({
       }}
       disabled={disabled}
     >
-      <TopbarButton
-        startIcon={<PlayCircleOutlineIcon />}
-        onClick={() => handleAction()}
-        disabled={disabled || loading}
-      >
-        {loading ? <>Starting&hellip;</> : "Start"}
-      </TopbarButton>
+      {mainButton}
       <BuildParametersPopover
         label="Start with build parameters"
         workspace={workspace}
@@ -89,12 +97,6 @@ export const StartButton: FC<ActionButtonPropsWithWorkspace> = ({
       />
     </ButtonGroup>
   );
-
-  return tooltipText ? (
-    <Tooltip title={tooltipText}>{buttonContent}</Tooltip>
-  ) : (
-    buttonContent
-  );
 };
 
 export const StopButton: FC<ActionButtonProps> = ({
