Move _getEtreeTag out of the class

gsnedders · gsnedders · commit 84cbc2052e65 · 2021-01-05T14:05:10.000Z
diff --git a/html5lib/treebuilders/etree.py b/html5lib/treebuilders/etree.py
@@ -16,6 +16,14 @@
 tag_regexp = re.compile("{([^}]*)}(.*)")
 
 
+def _getETreeTag(name, namespace):
+    if namespace is None:
+        etree_tag = name
+    else:
+        etree_tag = "{%s}%s" % (namespace, name)
+    return etree_tag
+
+
 def getETreeBuilder(ElementTreeImplementation, fullTree=False):
     ElementTree = ElementTreeImplementation
     ElementTreeCommentType = ElementTree.Comment("asd").tag
@@ -24,8 +32,7 @@ class Element(base.Node):
         def __init__(self, name, namespace=None):
             self._name = name
             self._namespace = namespace
-            self._element = ElementTree.Element(self._getETreeTag(name,
-                                                                  namespace))
+            self._element = ElementTree.Element(_getETreeTag(name, namespace))
             if namespace is None:
                 self.nameTuple = namespaces["html"], self._name
             else:
@@ -34,21 +41,14 @@ def __init__(self, name, namespace=None):
             self._childNodes = []
             self._flags = []
 
-        def _getETreeTag(self, name, namespace):
-            if namespace is None:
-                etree_tag = name
-            else:
-                etree_tag = "{%s}%s" % (namespace, name)
-            return etree_tag
-
         @property
         def name(self):
             return self._name
 
         @name.setter
         def name(self, name):
             self._name = name
-            self._element.tag = self._getETreeTag(self._name, self._namespace)
+            self._element.tag = _getETreeTag(self._name, self._namespace)
 
         @property
         def namespace(self):
@@ -57,7 +57,7 @@ def namespace(self):
         @namespace.setter
         def namespace(self, namespace):
             self._namespace = namespace
-            self._element.tag = self._getETreeTag(self._name, self._namespace)
+            self._element.tag = _getETreeTag(self._name, self._namespace)
 
         @property
         def attributes(self):
