-
Notifications
You must be signed in to change notification settings - Fork 29
Add "targets" Docs To Dev Server #13869
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
JamieB-gu
wants to merge
1
commit into
add-pages-and-targets-to-dev-server
Choose a base branch
from
add-targets-docs-to-dev-server
base: add-pages-and-targets-to-dev-server
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Add "targets" Docs To Dev Server #13869
JamieB-gu
wants to merge
1
commit into
add-pages-and-targets-to-dev-server
from
add-targets-docs-to-dev-server
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are four targets that DCAR can render content for, and this change adds documentation pages for each of them, on the following paths: - `/targets/dotcom` - `/targets/live-apps` - `/targets/editions-app` - `/targets/amp` The links on the `/targets` page now work. However the links on each of these new documentation pages do not yet point anywhere. These pages will be added in a future update, in the interests of keeping changes smaller and easier to review.
Size Change: 0 B Total Size: 966 kB ℹ️ View Unchanged
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are four targets that DCAR can render content for, and this change adds documentation pages for each of them, on the following paths:
/targets/dotcom
/targets/live-apps
/targets/editions-app
/targets/amp
The links on the
/targets
page now work. However the links on each of these new documentation pages do not yet point anywhere. These pages will be added in a future update, in the interests of keeping changes smaller and easier to review.Part of #13737, and relies on #13868 so draft for now.