Unvirtualize gdb_packet

h4tr3d · h4tr3d · commit f7a044effcf0 · 2019-04-01T11:53:46.000+10:00
diff --git a/gdb-packet.h b/gdb-packet.h
@@ -5,6 +5,7 @@
 
 enum class gdb_packet_type
 {
+    invalid,
     ack,
     nak,
     brk,
@@ -22,9 +23,9 @@ class gdb_packet
         complete
     };
 
-    virtual ~gdb_packet();
+    ~gdb_packet();
 
-    virtual gdb_packet_type type() const noexcept
+    gdb_packet_type type() const noexcept
     {
         if (m_data.size()) {
             switch (m_data[0]) {
@@ -38,7 +39,7 @@ class gdb_packet
                     return gdb_packet_type::brk;
             }
         }
-        return gdb_packet_type::generic;
+        return gdb_packet_type::invalid;
     }
 
     bool is_complete() const noexcept
@@ -76,9 +77,8 @@ class gdb_packet
         return m_state;
     }
 
-    size_t push_back(const char *data, size_t size)
+    size_t parse(const char *data, size_t size)
     {
-        //m_data.push_back(data, size);
         if (m_data.capacity() < m_data.size() + size) {
             m_data.reserve(m_data.size() + size);
         }

Original file line number	Diff line number	Diff line change
`@@ -5,6 +5,7 @@`
`5`	`5`
`6`	`6`	`enum class gdb_packet_type`
`7`	`7`	`{`
	`8`	`+ invalid,`
`8`	`9`	`ack,`
`9`	`10`	`nak,`
`10`	`11`	`brk,`
`@@ -22,9 +23,9 @@ class gdb_packet`
`22`	`23`	`complete`
`23`	`24`	`};`
`24`	`25`
`25`		`- virtual ~gdb_packet();`
	`26`	`+ ~gdb_packet();`
`26`	`27`
`27`		`- virtual gdb_packet_type type() const noexcept`
	`28`	`+ gdb_packet_type type() const noexcept`
`28`	`29`	`{`
`29`	`30`	`if (m_data.size()) {`
`30`	`31`	`switch (m_data[0]) {`
`@@ -38,7 +39,7 @@ class gdb_packet`
`38`	`39`	`return gdb_packet_type::brk;`
`39`	`40`	`}`
`40`	`41`	`}`
`41`		`- return gdb_packet_type::generic;`
	`42`	`+ return gdb_packet_type::invalid;`
`42`	`43`	`}`
`43`	`44`
`44`	`45`	`bool is_complete() const noexcept`
`@@ -76,9 +77,8 @@ class gdb_packet`
`76`	`77`	`return m_state;`
`77`	`78`	`}`
`78`	`79`
`79`		`- size_t push_back(const char *data, size_t size)`
	`80`	`+ size_t parse(const char *data, size_t size)`
`80`	`81`	`{`
`81`		`- //m_data.push_back(data, size);`
`82`	`82`	`if (m_data.capacity() < m_data.size() + size) {`
`83`	`83`	`m_data.reserve(m_data.size() + size);`
`84`	`84`	`}`