Merge pull request locutusjs#59 from martindrapeau/master

kvz · kvz · commit 55db06dedb17 · 2012-11-29T05:39:18.000-08:00
Infinite loop in strnatcasecmp
diff --git a/functions/strings/strnatcasecmp.js b/functions/strings/strnatcasecmp.js
@@ -114,6 +114,9 @@ function strnatcasecmp (str1, str2) {
     } else if (ca > cb) {
       return +1;
     }
+    
+    // prevent possible infinite loop
+    if (ia >= a.length && ib >= b.length) return 0;
 
     ++ia;
     ++ib;

Original file line number	Diff line number	Diff line change
`@@ -114,6 +114,9 @@ function strnatcasecmp (str1, str2) {`
`114`	`114`	`} else if (ca > cb) {`
`115`	`115`	`return +1;`
`116`	`116`	`}`
	`117`	`+`
	`118`	`+ // prevent possible infinite loop`
	`119`	`+ if (ia >= a.length && ib >= b.length) return 0;`
`117`	`120`
`118`	`121`	`++ia;`
`119`	`122`	`++ib;`