Optimize checksum verification #132
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do not store the entire release in memory, and instead stream the download through the checksum and file simultaneously.
|
|
radeksimko
reviewed
May 10, 2023
There was a problem hiding this comment.
Hi @ammario
I took some time to verify the performance difference through a benchmark and I can confirm reduction in memory usage worth ~80% - which is indeed amazing!
Aside from the minor in-line note this LGTM.
Co-authored-by: Radek Simko <radek.simko@gmail.com>
radeksimko
approved these changes
May 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not store the entire release in memory, and instead stream the download through the checksum and file simultaneously. This change will significantly help our test performance over at coder/coder.