cpp init 0

Yusuke Sugomori · Yusuke Sugomori · commit 41f7e864150c · 2013-02-12T15:44:54.000+09:00
diff --git a/cpp/DBN.cpp b/cpp/DBN.cpp
@@ -278,12 +278,14 @@ RBM::RBM(int size, int n_v, int n_h, double **w, double *hb, double *vb) {
 
   if(hb == NULL) {
     hbias = new double[n_hidden];
+    for(int i=0; i<n_hidden; i++) hbias[i] = 0;
   } else {
     hbias = hb;
   }
 
   if(vb == NULL) {
     vbias = new double[n_visible];
+    for(int i=0; i<n_visible; i++) vbias[i] = 0;
   } else {
     vbias = vb;
   }
@@ -404,6 +406,13 @@ LogisticRegression::LogisticRegression(int size, int in, int out) {
   W = new double*[n_out];
   for(int i=0; i<n_out; i++) W[i] = new double[n_in];
   b = new double[n_out];
+
+  for(int i=0; i<n_out; i++) {
+    for(int j=0; j<n_in; j++) {
+      W[i][j] = 0;
+    }
+    b[i] = 0;
+  }
 }
 
 LogisticRegression::~LogisticRegression() {
@@ -418,6 +427,7 @@ void LogisticRegression::train(int *x, int *y, double lr) {
   double *dy = new double[n_out];
 
   for(int i=0; i<n_out; i++) {
+    p_y_given_x[i] = 0;
     for(int j=0; j<n_in; j++) {
       p_y_given_x[i] += W[i][j] * x[j];
     }
@@ -454,6 +464,7 @@ void LogisticRegression::softmax(double *x) {
 
 void LogisticRegression::predict(int *x, double *y) {
   for(int i=0; i<n_out; i++) {
+    y[i] = 0;
     for(int j=0; j<n_in; j++) {
       y[i] += W[i][j] * x[j];
     }
diff --git a/cpp/LogisticRegression.cpp b/cpp/LogisticRegression.cpp
@@ -14,6 +14,13 @@ LogisticRegression::LogisticRegression(int size, int in, int out) {
   W = new double*[n_out];
   for(int i=0; i<n_out; i++) W[i] = new double[n_in];
   b = new double[n_out];
+
+  for(int i=0; i<n_out; i++) {
+    for(int j=0; j<n_in; j++) {
+      W[i][j] = 0;
+    }
+    b[i] = 0;
+  }
 }
 
 LogisticRegression::~LogisticRegression() {
@@ -28,6 +35,7 @@ void LogisticRegression::train(int *x, int *y, double lr) {
   double *dy = new double[n_out];
 
   for(int i=0; i<n_out; i++) {
+    p_y_given_x[i] = 0;
     for(int j=0; j<n_in; j++) {
       p_y_given_x[i] += W[i][j] * x[j];
     }
@@ -63,6 +71,7 @@ void LogisticRegression::softmax(double *x) {
 
 void LogisticRegression::predict(int *x, double *y) {
   for(int i=0; i<n_out; i++) {
+    y[i] = 0;
     for(int j=0; j<n_in; j++) {
       y[i] += W[i][j] * x[j];
     }
@@ -74,6 +83,8 @@ void LogisticRegression::predict(int *x, double *y) {
 
 
 void test_lr() {
+  srand(0);
+  
   double learning_rate = 0.1;
   double n_epochs = 500;
 
diff --git a/cpp/RBM.cpp b/cpp/RBM.cpp
@@ -47,12 +47,14 @@ RBM::RBM(int size, int n_v, int n_h, double **w, double *hb, double *vb) {
 
   if(hb == NULL) {
     hbias = new double[n_hidden];
+    for(int i=0; i<n_hidden; i++) hbias[i] = 0;
   } else {
     hbias = hb;
   }
 
   if(vb == NULL) {
     vbias = new double[n_visible];
+    for(int i=0; i<n_visible; i++) vbias[i] = 0;
   } else {
     vbias = vb;
   }

Original file line number	Diff line number	Diff line change
`@@ -47,12 +47,14 @@ RBM::RBM(int size, int n_v, int n_h, double *w, double hb, double *vb) {`
`47`	`47`
`48`	`48`	`if(hb == NULL) {`
`49`	`49`	`hbias = new double[n_hidden];`
	`50`	`+ for(int i=0; i<n_hidden; i++) hbias[i] = 0;`
`50`	`51`	`} else {`
`51`	`52`	`hbias = hb;`
`52`	`53`	`}`
`53`	`54`
`54`	`55`	`if(vb == NULL) {`
`55`	`56`	`vbias = new double[n_visible];`
	`57`	`+ for(int i=0; i<n_visible; i++) vbias[i] = 0;`
`56`	`58`	`} else {`
`57`	`59`	`vbias = vb;`
`58`	`60`	`}`