Skip to content

Refactor websocket #87

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 25 commits into from
Aug 7, 2019
Merged

Refactor websocket #87

merged 25 commits into from
Aug 7, 2019

Conversation

john-deng
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Aug 7, 2019

Codecov Report

Merging #87 into master will decrease coverage by 0.01%.
The diff coverage is 98.71%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #87      +/-   ##
==========================================
- Coverage   99.83%   99.81%   -0.02%     
==========================================
  Files         102      104       +2     
  Lines        3638     3790     +152     
==========================================
+ Hits         3632     3783     +151     
  Misses          4        4              
- Partials        2        3       +1
Impacted Files Coverage Δ
pkg/factory/instantiate/instantiate.go 100% <ø> (ø) ⬆️
pkg/starter/jwt/jwtmiddleware.go 100% <100%> (ø) ⬆️
pkg/inject/inject.go 100% <100%> (ø) ⬆️
pkg/app/application.go 100% <100%> (ø) ⬆️
pkg/app/web/application.go 100% <100%> (ø) ⬆️
pkg/inject/injecttag.go 100% <100%> (ø) ⬆️
pkg/app/web/dispatcher.go 100% <100%> (ø) ⬆️
pkg/inject/defaulttag.go 100% <100%> (ø) ⬆️
pkg/inject/valuetag.go 100% <100%> (ø) ⬆️
pkg/app/web/testapplication.go 100% <100%> (ø) ⬆️
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d0e18b6...f812ba6. Read the comment docs.

@john-deng john-deng merged commit 392da0f into master Aug 7, 2019
@john-deng john-deng deleted the refactor-websocket branch September 30, 2019 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant