Using universal references in logging templates.

Klaim · Klaim · commit 69b649979124 · 2012-11-15T12:49:22.000+01:00
diff --git a/include/network/logging/logging.hpp b/include/network/logging/logging.hpp
@@ -43,7 +43,7 @@ class log_record
   }
   
   template< typename TypeOfSomething >
-  log_record& write( const TypeOfSomething& something ) // THINK: use universal references?
+  log_record& write( TypeOfSomething&& something )
   {
     m_text_stream << something;
     return *this;
@@ -61,9 +61,9 @@ class log_record
 };
   
 template< typename TypeOfSomething >
-inline log_record& operator<<( log_record& log, const TypeOfSomething& something ) // THINK: use universal references?
+inline log_record& operator<<( log_record& log, TypeOfSomething&& something )
 {
-  return log.write( something );
+  return log.write( std::forward<TypeOfSomething>(something) );
 }
 
 }}
diff --git a/libs/network/test/http/cpp-netlib-http-client_get_test.dir/Debug/link.5192-cvtres.read.1.tlog b/libs/network/test/http/cpp-netlib-http-client_get_test.dir/Debug/link.5192-cvtres.read.1.tlog
@@ -0,0 +1 @@
+��
diff --git a/libs/network/test/http/cpp-netlib-http-client_get_test.dir/Debug/link.5192-cvtres.write.1.tlog b/libs/network/test/http/cpp-netlib-http-client_get_test.dir/Debug/link.5192-cvtres.write.1.tlog
@@ -0,0 +1 @@
+��
diff --git a/libs/network/test/http/cpp-netlib-http-client_get_test.dir/Debug/link.5192-rc.read.1.tlog b/libs/network/test/http/cpp-netlib-http-client_get_test.dir/Debug/link.5192-rc.read.1.tlog
@@ -0,0 +1 @@
+��
diff --git a/libs/network/test/http/cpp-netlib-http-client_get_test.dir/Debug/link.5192-rc.write.1.tlog b/libs/network/test/http/cpp-netlib-http-client_get_test.dir/Debug/link.5192-rc.write.1.tlog
@@ -0,0 +1 @@
+��
diff --git a/libs/network/test/http/cpp-netlib-http-client_get_test.dir/Debug/link.5192.read.1.tlog b/libs/network/test/http/cpp-netlib-http-client_get_test.dir/Debug/link.5192.read.1.tlog
@@ -0,0 +1 @@
+��
diff --git a/libs/network/test/http/cpp-netlib-http-client_get_test.dir/Debug/link.5192.write.1.tlog b/libs/network/test/http/cpp-netlib-http-client_get_test.dir/Debug/link.5192.write.1.tlog
@@ -0,0 +1 @@
+��

Original file line number	Diff line number	Diff line change
`@@ -43,7 +43,7 @@ class log_record`
`43`	`43`	`}`
`44`	`44`
`45`	`45`	`template< typename TypeOfSomething >`
`46`		`- log_record& write( const TypeOfSomething& something ) // THINK: use universal references?`
	`46`	`+ log_record& write( TypeOfSomething&& something )`
`47`	`47`	`{`
`48`	`48`	`m_text_stream << something;`
`49`	`49`	`return *this;`
`@@ -61,9 +61,9 @@ class log_record`
`61`	`61`	`};`
`62`	`62`
`63`	`63`	`template< typename TypeOfSomething >`
`64`		`-inline log_record& operator<<( log_record& log, const TypeOfSomething& something ) // THINK: use universal references?`
	`64`	`+inline log_record& operator<<( log_record& log, TypeOfSomething&& something )`
`65`	`65`	`{`
`66`		`- return log.write( something );`
	`66`	`+ return log.write( std::forward<TypeOfSomething>(something) );`
`67`	`67`	`}`
`68`	`68`
`69`	`69`	`}}`