Use quote_ident() to allow databases with spaces in the names

cadnce · cadnce · commit 15210d15504a · 2016-12-06T22:10:12.000Z
* Added an exception when the paramters will create a malformed request.
* Updated the tests around this to use a named databse instead.
diff --git a/influxdb/client.py b/influxdb/client.py
@@ -485,15 +485,15 @@ def create_database(self, dbname):
         :param dbname: the name of the database to create
         :type dbname: str
         """
-        self.query("CREATE DATABASE \"%s\"" % dbname)
+        self.query("CREATE DATABASE {0}".format(quote_ident(dbname)))
 
     def drop_database(self, dbname):
         """Drop a database from InfluxDB.
 
         :param dbname: the name of the database to drop
         :type dbname: str
         """
-        self.query("DROP DATABASE \"%s\"" % dbname)
+        self.query("DROP DATABASE {0}".format(quote_ident(dbname)))
 
     def create_retention_policy(self, name, duration, replication,
                                 database=None, default=False):
@@ -517,9 +517,10 @@ def create_retention_policy(self, name, duration, replication,
         :type default: bool
         """
         query_string = \
-            "CREATE RETENTION POLICY \"%s\" ON \"%s\" " \
-            "DURATION %s REPLICATION %s" % \
-            (name, database or self._database, duration, replication)
+            "CREATE RETENTION POLICY {0} ON {1} " \
+            "DURATION {2} REPLICATION {3}".format(
+                quote_ident(name), quote_ident(database or self._database),
+                duration, replication)
 
         if default is True:
             query_string += " DEFAULT"
@@ -597,8 +598,15 @@ def get_list_retention_policies(self, database=None):
               u'name': u'default',
               u'replicaN': 1}]
             """
+
+        if not (database or self._database):
+            raise InfluxDBClientError(
+                "get_list_retention_policies() requires a database as a "
+                "parameter or the client to be using a database")
+
         rsp = self.query(
-            "SHOW RETENTION POLICIES ON \"%s\"" % (database or self._database)
+            "SHOW RETENTION POLICIES ON {0}".format(
+                quote_ident(database or self._database))
         )
         return list(rsp.get_points())
 
diff --git a/influxdb/tests/client_test.py b/influxdb/tests/client_test.py
@@ -591,7 +591,7 @@ def test_get_list_retention_policies(self):
                 text=example_response
             )
             self.assertListEqual(
-                self.cli.get_list_retention_policies(),
+                self.cli.get_list_retention_policies("db"),
                 [{'duration': '24h0m0s',
                   'name': 'fsfdsdf', 'replicaN': 2}]
             )

Original file line number	Diff line number	Diff line change
`@@ -591,7 +591,7 @@ def test_get_list_retention_policies(self):`
`591`	`591`	`text=example_response`
`592`	`592`	`)`
`593`	`593`	`self.assertListEqual(`
`594`		`- self.cli.get_list_retention_policies(),`
	`594`	`+ self.cli.get_list_retention_policies("db"),`
`595`	`595`	`[{'duration': '24h0m0s',`
`596`	`596`	`'name': 'fsfdsdf', 'replicaN': 2}]`
`597`	`597`	`)`