Add Fluss+ Button integration #139925
Draft
Add Fluss+ Button integration #139925
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added some contextual names
Co-authored-by: Josef Zweck <josef@zweck.dev>
Co-authored-by: Josef Zweck <josef@zweck.dev>
Co-authored-by: Josef Zweck <josef@zweck.dev>
Co-authored-by: Josef Zweck <josef@zweck.dev>
joostlek
requested changes
May 14, 2025
Comment on lines
35
to
38
| await self.async_set_unique_id(DOMAIN) | ||
|
|
||
| if self._async_current_entries(): | ||
| return self.async_abort(reason="single_instance_allowed") |
There was a problem hiding this comment.
Why do we only allow one instance?
There was a problem hiding this comment.
The user only needs to add it once since the api key is connect to their account which is able to get the devices they have access to.
There was a problem hiding this comment.
Right, but why can't there be 2 users?
There was a problem hiding this comment.
Fair point, removing the config for that.
joostlek
requested changes
Jun 12, 2025
Comment on lines
35
to
38
| await self.async_set_unique_id(DOMAIN) | ||
|
|
||
| if self._async_current_entries(): | ||
| return self.async_abort(reason="single_instance_allowed") |
There was a problem hiding this comment.
Right, but why can't there be 2 users?
joostlek
requested changes
Jun 17, 2025
Co-authored-by: Joost Lekkerkerker <joostlek@outlook.com>
zweckj
requested changes
Jul 16, 2025
Comment on lines
+27
to
+31
| entities: list[FlussButton] = [] | ||
| for device_id, device in devices.items(): | ||
| entities.append(FlussButton(coordinator, device_id, device)) | ||
|
|
||
| async_add_entities(entities) |
There was a problem hiding this comment.
Suggested change
| entities: list[FlussButton] = [] | |
| for device_id, device in devices.items(): | |
| entities.append(FlussButton(coordinator, device_id, device)) | |
| async_add_entities(entities) | |
| async_add_entities(FlussButton(coordinator, device_id, device) for device_id, device in devices.items()) |
Comment on lines
+50
to
+53
| @property | ||
| def available(self) -> bool: | ||
| """Return if the entity is available.""" | ||
| return self.coordinator.last_update_success |
There was a problem hiding this comment.
Suggested change
| @property | |
| def available(self) -> bool: | |
| """Return if the entity is available.""" | |
| return self.coordinator.last_update_success |
is the default for coordinator entities
Comment on lines
+39
to
+42
| @property | ||
| def available(self) -> bool: | ||
| """Return if the entity is available.""" | ||
| return super().available and self.device_id in self.coordinator.data |
There was a problem hiding this comment.
Suggested change
| @property | |
| def available(self) -> bool: | |
| """Return if the entity is available.""" | |
| return super().available and self.device_id in self.coordinator.data |
not used atm
| self, | ||
| coordinator: FlussDataUpdateCoordinator, | ||
| device_id: str, | ||
| device: dict | None = None, |
There was a problem hiding this comment.
why would the device even be None, we probably shouldn't setup the entity if we don't have that device. That'll also simplify the code below
Comment on lines
+33
to
+37
| def name(self) -> str: | ||
| """Use the deviceName field for the entity name.""" | ||
| return ( | ||
| self.device.get("deviceName", super().name) if self.device else super().name | ||
| ) |
There was a problem hiding this comment.
probably rather add a proper home assistant device to your entity _attr_device_info. If that is the main entity of the device you can set _attr_name to None, so it'll take the device's name
| assert result["errors"] == {} | ||
|
|
||
|
|
||
| async def test_step_user_success(config_flow: FlussConfigFlow) -> None: |
There was a problem hiding this comment.
init your flows with
result = await hass.config_entries.flow.async_init(
DOMAIN, context={"source": SOURCE_USER}
)| mock_client.return_value = None | ||
| result = await config_flow.async_step_user(user_input) | ||
|
|
||
| assert result["type"] == FlowResultType.CREATE_ENTRY |
There was a problem hiding this comment.
Suggested change
| assert result["type"] == FlowResultType.CREATE_ENTRY | |
| assert result["type"] is FlowResultType.CREATE_ENTRY |
is to compare enums
Comment on lines
+51
to
+68
| async def test_step_user_invalid_auth(config_flow: FlussConfigFlow) -> None: | ||
| """Test invalid authentication.""" | ||
| user_input = {CONF_API_KEY: "invalid_api_key"} | ||
|
|
||
| with patch("homeassistant.components.fluss.config_flow.FlussApiClient") as mock_client: | ||
| mock_client.side_effect = FlussApiClientAuthenticationError | ||
| result = await config_flow.async_step_user(user_input) | ||
|
|
||
| assert result["type"] == FlowResultType.FORM | ||
| assert result["step_id"] == "user" | ||
| assert result["errors"] == {"base": "invalid_auth"} | ||
|
|
||
|
|
||
| async def test_step_user_cannot_connect(config_flow: FlussConfigFlow) -> None: | ||
| """Test connection failure.""" | ||
| user_input = {CONF_API_KEY: "some_api_key"} | ||
|
|
||
| with patch("homeassistant.components.fluss.config_flow.FlussApiClient") as mock_client: |
Comment on lines
+101
to
+112
| def test_data_schema_validation(): | ||
| """Test that the data schema enforces required string field.""" | ||
| # Valid input | ||
| STEP_USER_DATA_SCHEMA({CONF_API_KEY: "test_key"}) | ||
|
|
||
| # Missing key | ||
| with pytest.raises(vol.error.MultipleInvalid): | ||
| STEP_USER_DATA_SCHEMA({}) | ||
|
|
||
| # Non-string value | ||
| with pytest.raises(vol.error.MultipleInvalid): | ||
| STEP_USER_DATA_SCHEMA({CONF_API_KEY: 123}) |
There was a problem hiding this comment.
you don't need to test that, HA takes care of that
Comment on lines
+19
to
+27
| @pytest.fixture | ||
| async def mock_hass(): | ||
| """Mock Hass Environment.""" | ||
| hass = AsyncMock(spec=HomeAssistant) | ||
| hass.config_entries = AsyncMock() | ||
| hass.config_entries.async_forward_entry_setups = AsyncMock() | ||
| hass.config_entries.async_unload_platforms = AsyncMock() | ||
| hass.data = {} | ||
| return hass |
There was a problem hiding this comment.
move common fixtures to conftest.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: