Skip to content

Add switch for AC's air_clean, ventilator and washers #140842

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: dev
Choose a base branch
from

Conversation

LG-ThinQ-Integration
Copy link
Contributor

@LG-ThinQ-Integration LG-ThinQ-Integration commented Mar 18, 2025

Breaking change

  • The WASHTOWER_DRYER's operation API mismatch issue has been fixed.

Proposed change

  1. Air conditioner: air_clean switch
  2. Ventilator: main switch
  3. Improve washing machine control by separating operations into switches and buttons depending on it's device_state. (washer, dryer, dishwasher, styler, etc, 9 types of devices)
    _washer_start_pause

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@YunseonPark-LGE YunseonPark-LGE force-pushed the pr_washer_switch_25.03 branch from ea28e02 to 7f6e5ea Compare March 18, 2025 02:15
@LG-ThinQ-Integration LG-ThinQ-Integration changed the title Add switch for AC's air_clean, ventilator and washers Add switch for AC's air_clean, ventilator and washer's conditional entity Mar 18, 2025
@LG-ThinQ-Integration LG-ThinQ-Integration marked this pull request as ready for review March 18, 2025 02:43
@LG-ThinQ-Integration LG-ThinQ-Integration marked this pull request as draft March 18, 2025 06:10
@YunseonPark-LGE YunseonPark-LGE force-pushed the pr_washer_switch_25.03 branch from 7f6e5ea to 0117985 Compare March 18, 2025 06:25
@LG-ThinQ-Integration LG-ThinQ-Integration changed the title Add switch for AC's air_clean, ventilator and washer's conditional entity Add switch for AC's air_clean, ventilator and washers Mar 20, 2025
@LG-ThinQ-Integration LG-ThinQ-Integration marked this pull request as ready for review March 20, 2025 06:13
@YunseonPark-LGE YunseonPark-LGE force-pushed the pr_washer_switch_25.03 branch from f7dbad2 to 03dd4f5 Compare April 7, 2025 03:24
@YunseonPark-LGE YunseonPark-LGE force-pushed the pr_washer_switch_25.03 branch from e456dd4 to 070917a Compare April 22, 2025 02:16
@LG-ThinQ-Integration LG-ThinQ-Integration marked this pull request as draft April 22, 2025 02:19
@LG-ThinQ-Integration LG-ThinQ-Integration marked this pull request as ready for review April 22, 2025 03:02
@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@home-assistant home-assistant bot marked this pull request as draft May 14, 2025 11:25
@LG-ThinQ-Integration LG-ThinQ-Integration marked this pull request as ready for review May 16, 2025 07:27
@home-assistant home-assistant bot requested a review from joostlek May 16, 2025 07:27
@LG-ThinQ-Integration
Copy link
Contributor Author

@joostlek
Please review this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants