Make isy amaze balls #3082

Teagan42 · 2016-08-31T20:16:35Z

Description:
The ISY994 platform is woefully incomplete. Update the platform to automatically discover covers, binary sensors, sensors, switches, lights, locks, etc. The PyISY library was updated to return the unit of measurement for devices, this allows sensors to display their value with unites or as a state.

Unit tests incoming - if I have time.

Related issue (if applicable): fixes #3037

Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#893

Example entry for configuration.yaml (if applicable):

isy994:
    host: 192.168.1.129
    username: admin
    password: admin
    tls: 1.2
    hidden_string: hidden
    sensor_string: sensor

Checklist:

If user exposed functionality or configuration variables are added/changed:

Documentation added/updated in home-assistant.io

If code communicates with devices, web services, or a:

Local tests with tox run successfully. Your PR cannot be merged unless tests pass
New dependencies have been added to the REQUIREMENTS variable (example).
New dependencies are only imported inside functions that use them (example).
New dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
New files were added to .coveragerc.

If the code does not interact with devices:

Local tests with tox run successfully. Your PR cannot be merged unless tests pass
Tests have been added to verify that the new code works.

…h backwards compatibility.

kellerza · 2016-09-04T08:51:03Z

homeassistant/components/isy994.py

+
+HIDDEN_STRING = DEFAULT_HIDDEN_STRING
+
+COMPONENTS = ['lock', 'binary_sensor', 'cover', 'fan', 'sensor', 'light',


PLATFORMS or SUPPORTED_PLATFORMS ?

Teagan42 · 2016-09-07T03:24:25Z

Gonna write unit tests tomorrow.

hoopty · 2016-09-10T17:00:17Z

Any chance this can get into 0.28?

kellerza · 2016-09-10T19:49:59Z

This looks good, but @Teagan42 seems to want to add unit tests. ISY is part of .coveragerc, so not critical - but this is a massive change to ISY, so probably better

Teagan42 · 2016-09-11T16:03:18Z

@kellerza - with my new job, I haven't had time to do everything I wanted.
Go ahead and merge it when you feel good. I'll do tests when I get a chance
(hah!)

On Sat, Sep 10, 2016 at 1:50 PM, Johann Kellerman notifications@github.com
wrote:

This looks good, but @Teagan42 https://github.com/Teagan42 seems to
want to add unit tests. ISY is part of .coveragerc, so not critical - but
this is a massive change to ISY, so probably better

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#3082 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AC2fZeaiiLrWeDvUkVEAlRUPzJp6FLbMks5qownvgaJpZM4JyBH8
.

kellerza · 2016-09-11T18:12:12Z

@Teagan42 good luck with the new job!

0.28 is out, so there are 2 weeks to test in dev branch 🔥

@sytone @hoopty feedback would be great. If you don't run dev do you mind copying the isy files to .homeassistant/custom_components and testing it? (download the raw component from here and for all the platforms)

hoopty · 2016-09-12T05:43:05Z

I have tested on dev branch and its working as expected - no issues found so far. Thanks @Teagan42 and best of luck on the new gig.

hoopty · 2016-09-15T06:28:05Z

Well, I have found something in the dev branch that isn't working like it does in 0.28.2

I have two lamp modules (not dimmers) that show up here:

16-09-15 01:21:41 homeassistant.components.isy994: ISY Updated Node: ZW002_1
16-09-15 01:21:41 homeassistant.components.isy994: ISY Updated Node: ZW003_1
16-09-15 01:21:41 homeassistant.loader: Loaded switch.isy994 from homeassistant.components.switch.isy994

But the corresponding switch entities are not appearing. Will turn up more logging on the isy component and report back.

hoopty · 2016-09-15T06:44:17Z

Not much, but here's the logging I got. I have a z-wave mimolite device (seen below as ZW005_*) that does have the with entities show up in HA. The ones not working are ZW002 & ZW003, which are the following device: Leviton VRPD3-1LW Vizia RF Series 300-watt Scene Capable Plug-In Lamp Dimming Module. They are working in the latest release.

16-09-15 01:29:54 homeassistant.components.isy994: ISY Update Received:
<?xml version="1.0"?><Event seqnum="7" sid="uuid:81"><control>ST</control><action uom="51" prec="0">0</action><node>ZW002_1</node><eventInfo></eventInfo></Event
16-09-15 01:29:54 homeassistant.components.isy994: ISY Updated Node: ZW002_1
16-09-15 01:29:54 homeassistant.components.isy994: ISY Update Received:
<?xml version="1.0"?><Event seqnum="8" sid="uuid:81"><control>ST</control><action uom="51" prec="0">0</action><node>ZW003_1</node><eventInfo></eventInfo></Event
16-09-15 01:29:54 homeassistant.components.isy994: ISY Updated Node: ZW003_1
16-09-15 01:29:54 homeassistant.components.isy994: ISY Update Received:
<?xml version="1.0"?><Event seqnum="9" sid="uuid:81"><control>ERR</control><action>0</action><node>ZW004_1</node><eventInfo></eventInfo></Event>
16-09-15 01:29:54 homeassistant.components.isy994: ISY Update Received:
<?xml version="1.0"?><Event seqnum="10" sid="uuid:81"><control>ST</control><action uom="78" prec="0">0</action><node>ZW004_1</node><eventInfo></eventInfo></Even
16-09-15 01:29:54 homeassistant.components.isy994: ISY Updated Node: ZW004_1
16-09-15 01:29:54 homeassistant.components.isy994: ISY Update Received:
<?xml version="1.0"?><Event seqnum="11" sid="uuid:81"><control>ST</control><action uom="78" prec="0">100</action><node>ZW004_104</node><eventInfo></eventInfo></
16-09-15 01:29:54 homeassistant.components.isy994: ISY Updated Node: ZW004_104
16-09-15 01:29:54 homeassistant.components.isy994: ISY Update Received:
<?xml version="1.0"?><Event seqnum="12" sid="uuid:81"><control>GPV</control><action uom="56" prec="2">285000</action><node>ZW004_118</node><eventInfo></eventInf

Teagan42 · 2016-09-15T16:29:53Z

I found a few other issues - I'll be making a PR here shortly

On Thu, Sep 15, 2016 at 12:44 AM, Bryce Edwards notifications@github.com
wrote:

Not much, but here's the logging I got. I have a z-wave mimolite device
(seen below as ZW005_*) that does have the with entities show up in HA. The
ones not working are ZW002 & ZW003, which are the following device: Leviton
VRPD3-1LW Vizia RF Series 300-watt Scene Capable Plug-In Lamp Dimming
Module. They are working in the latest release.

16-09-15 01:29:54 homeassistant.components.isy994: ISY Update Received:
ST0ZW002_116-09-15 01:29:54 homeassistant.components.isy994: ISY Updated Node: ZW002_1
16-09-15 01:29:54 homeassistant.components.isy994: ISY Update Received:
ST0ZW003_116-09-15 01:29:54 homeassistant.components.isy994: ISY Updated Node: ZW003_1
16-09-15 01:29:54 homeassistant.components.isy994: ISY Update Received:
ERR0ZW004_1
16-09-15 01:29:54 homeassistant.components.isy994: ISY Update Received:
ST0ZW004_116-09-15 01:29:54 homeassistant.components.isy994: ISY Updated Node: ZW004_1
16-09-15 01:29:54 homeassistant.components.isy994: ISY Update Received:
ST100ZW004_10416-09-15 01:29:54 homeassistant.components.isy994: ISY Updated Node: ZW004_104
16-09-15 01:29:54 homeassistant.components.isy994: ISY Update Received:
GPV285000ZW004_118—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#3082 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AC2fZYO-NPtvLLTXMd4wNdDscQV_UWu_ks5qqOlKgaJpZM4JyBH8
.

Teagan42 added 30 commits August 30, 2016 11:40

ISY Lock

5227a1e

Update isy platform

bf61b21

Isy Binary Sensor component

a220247

Remove debug log

3da9492

Add cover to list of components

7bf90e7

Isy cover devices

54281c7

Sensor units

783d425

Update units

44a7184

Don't import binary sensors

edecc07

Add isy fan support

82aa4d6

Add fan to list of isy components

d22b589

Sensors

2625c10

Add length check

1d37de0

Add attribute check

c29ee0f

Ugly logger

56f4734

Filter and unit fixes

1380860

Update states

29852d2

Small updates

9baa64e

PyDoc strings

dad31d6

Linting

1b78548

Fix is closed

be9350d

Update

9f59321

Change pyisy import because travis

6f83c32

May not like typing...

743441a

Fix reference

ba89696

Need to set module property to check instance

5bb68cf

Add linting disable

40544fc

Program folder should start with HA. then domain - to help keep wit…

1fa6030

…h backwards compatibility.

Reduce pydoc length

16b7c47

Typings and some more pydocs

370772d

kellerza reviewed Sep 4, 2016
View reviewed changes

Teagan42 added 9 commits September 4, 2016 09:51

Disable unused argument

8224468

Rename variable

14abd30

Fix copy-pasta artifact in comments

a14afb2

Clean up ISY994 cover state

11df01c

Clean up isy994 fan state

33e9e78

Fix isy994 default config values

99455d8

Fix isy994 binary sensor state

808c1a7

Linting

4acbec6

Do as @kellerza says

da78948

fabaff mentioned this pull request Sep 7, 2016

Use voluptuous #2800

Closed

kellerza merged commit 05a3b61 into home-assistant:dev Sep 11, 2016

dethpickle mentioned this pull request Nov 28, 2016

ISY dimmable lights turn_on to 100 brightness by default #4619

Closed

home-assistant locked and limited conversation to collaborators Mar 17, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Make isy amaze balls #3082

Make isy amaze balls #3082

Uh oh!

Teagan42 commented Aug 31, 2016 •

edited

Loading

Uh oh!

kellerza Sep 4, 2016

Uh oh!

Teagan42 commented Sep 7, 2016

Uh oh!

hoopty commented Sep 10, 2016

Uh oh!

kellerza commented Sep 10, 2016

Uh oh!

Teagan42 commented Sep 11, 2016

Uh oh!

kellerza commented Sep 11, 2016

Uh oh!

hoopty commented Sep 12, 2016

Uh oh!

hoopty commented Sep 15, 2016

Uh oh!

hoopty commented Sep 15, 2016

Uh oh!

Teagan42 commented Sep 15, 2016

Uh oh!

Uh oh!


		HIDDEN_STRING = DEFAULT_HIDDEN_STRING

		COMPONENTS = ['lock', 'binary_sensor', 'cover', 'fan', 'sensor', 'light',

Uh oh!

Make isy amaze balls #3082

Make isy amaze balls #3082

Uh oh!

Conversation

Teagan42 commented Aug 31, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kellerza Sep 4, 2016

Choose a reason for hiding this comment

Uh oh!

Teagan42 commented Sep 7, 2016

Uh oh!

hoopty commented Sep 10, 2016

Uh oh!

kellerza commented Sep 10, 2016

Uh oh!

Teagan42 commented Sep 11, 2016

Uh oh!

kellerza commented Sep 11, 2016

Uh oh!

hoopty commented Sep 12, 2016

Uh oh!

hoopty commented Sep 15, 2016

Uh oh!

hoopty commented Sep 15, 2016

Uh oh!

Teagan42 commented Sep 15, 2016

Uh oh!

Uh oh!

Teagan42 commented Aug 31, 2016 •

edited

Loading