Update netatmo.markdown #11770
Merged
Update netatmo.markdown #11770
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove documentation about (temporarily) removed features and configuration options.
9 tasks
fabaff
approved these changes
Jan 20, 2020
ochlocracy
pushed a commit
to ochlocracy/home-assistant.io
that referenced
this pull request
Jan 22, 2020
Remove documentation about (temporarily) removed features and configuration options.
rugaard
reviewed
Feb 7, 2020
| description: The `client id` from your Netatmo app. | ||
| required: true | ||
| type: string | ||
| secret_key: | ||
| client_secret: | ||
| description: The `client secret` from your Netatmo app. | ||
| required: true | ||
| type: integer |
There was a problem hiding this comment.
I know I'm late to the party, but I'm pretty confused from the docs.
How can this ever be an integer? It's always be a string. It's even a string in the provided screenshot?
There was a problem hiding this comment.
@rugaard well spotted. Thanks. Do you mind fixing it and opening a PR?
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Remove documentation about (temporarily) removed features and configuration options.
Pull request in home-assistant (if applicable): home-assistant/core#29851
Checklist:
nextis for changes and new documentation that will go public with the next Home Assistant release. Fixes, changes and adjustments for the current release should be created againstcurrent.