Skip to content

Update sensor.buienradar.markdown text #3036

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 22, 2017
Merged

Update sensor.buienradar.markdown text #3036

merged 1 commit into from
Jul 22, 2017

Conversation

IoTmessenger
Copy link
Contributor

While implementing the buienradar sensor, I have noticed some sensors not showing up in my card. Some monitored_conditions were missing an '_' in their naming convention. I have already made the changes in the text above.

Description:

Pull request in home-assistant (if applicable): home-assistant/home-assistant#

@IoTmessenger
Update sensor.buienradar.markdown text
2c035d8 
While implementing the buienradar sensor, I have noticed some sensors not showing up in my card. Some monitored_conditions were missing an '_' in their naming convention. I have already made the changes in the text above.
@mention-bot
Copy link

@IoTmessenger, thanks for your PR! By analyzing the history of the files in this pull request, we identified @mjj4791, @fabaff and @basschipper to be potential reviewers.

fabaff
fabaff approved these changes Jul 22, 2017
View reviewed changes
Copy link
Member

@fabaff fabaff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🐦

@fabaff fabaff merged commit 4c27e02 into home-assistant:current Jul 22, 2017
This was referenced Jul 23, 2017
Closed
Merged
fabaff pushed a commit that referenced this pull request Jul 23, 2017
@IoTmessenger @fabaff
Revert "Update sensor.buienradar.markdown text" (#3042)
d29eb9a 
* Revert "Update installation.markdown"

This reverts commit 83f1bfd.

* Revert "Update"

This reverts commit 67d5dd9.

* Revert "Update sensor.buienradar.markdown text (#3036)"

This reverts commit 4c27e02.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabaff fabaff fabaff approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@IoTmessenger @mention-bot @fabaff