Syncthru Printer description #4707
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
7 tasks
frenck
requested changes
Mar 13, 2018
| comments: false | ||
| sharing: true | ||
| footer: true | ||
| logo: # where do I place this |
There was a problem hiding this comment.
How do you handle copyright issues? Where to store information that we are allowed to use brand logos?
frenck
approved these changes
Mar 18, 2018
frenck
requested changes
Mar 18, 2018
| default: all values | ||
| type: list | ||
| keys: | ||
| toner_black: |
There was a problem hiding this comment.
The descriptions for each of these keys are missing.
@nielstron Could you please add them?
There was a problem hiding this comment.
Added descriptions
frenck
approved these changes
Mar 19, 2018
|
Thanks, @nielstron! I'll go ahead and merge this one in, since the parent PR has been merged already. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Adding a samsung syncthru printer component
Pull request in home-assistant (if applicable): home-assistant/core#13134
Checklist:
current. New documentation for platforms/components and features should go tonext.