Skip to content

Updated with new path. #4957

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 19, 2018
Merged

Updated with new path. #4957

merged 1 commit into from
Mar 19, 2018

Conversation

CCOSTAN
Copy link
Contributor

@CCOSTAN CCOSTAN commented Mar 19, 2018

Description:

Pull request in home-assistant (if applicable): home-assistant/home-assistant#

Checklist:

  • Branch: Fixes, changes and adjustments should be created against current. New documentation for platforms/components and features should go to next.
  • The documentation follow the standards.

Copy link
Contributor

@NovapaX NovapaX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The examples present in in the documentation cover about the exact same topic as the linked package. Besides: that package link to custom-ui resources, so i'ts not really 'drop in'. And it's not exactly a great example (lots of commented config)

I think we should remove this as it could lead to more user confusion (and broken links in our documentation)
If needed the inline examples could be extended with another notification example, but currently they communicate the possibilities pretty well.

P.S. I just visited your GitHub page, all I can say is: WOW! 🥇

@frenck
Copy link
Member

frenck commented Mar 19, 2018

For now, it is a fix, since the current is invalid.
Therefore, I'm accepting this PR.

@NovapaX Feel free to propose a change in a separate ticket or PR.

@frenck frenck merged commit 6f1c191 into home-assistant:current Mar 19, 2018
@CCOSTAN CCOSTAN deleted the patch-49 branch March 19, 2018 14:51
@CCOSTAN
Copy link
Contributor Author

CCOSTAN commented Mar 19, 2018

@NovapaX - Thanks for the comments. Glad you liked the Repo.. I try hard to keep it useful. I made some changes to my package based on your suggestions. I removed all the extra commented lines from the bottom (I forgot they were there) and rearranged the service actions to put the local resource items to the bottom. I also added a single remove everything below this line comment in the file for users who want to use it as a true 'drop in ' package. Thanks for the suggestions. Definitely made the result better!

Hopefully we can keep the links since i do believe my repo and the podcast are great resources for new users and little things that we can do to expose them is beneficial to all.

nielstron pushed a commit to nielstron/home-assistant.github.io that referenced this pull request Mar 22, 2018
@mib1185 mib1185 mentioned this pull request Oct 14, 2024
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants