Add documentation for integration of Vallox ventilation units #9668
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
frenck
requested changes
Jun 21, 2019
There was a problem hiding this comment.
@andre-richter I've reviewed as well, and found some additional comments. Could you please take a look? Awesome! 👍
Co-Authored-By: Franck Nijhof <frenck@frenck.nl>
|
Sure, thanks for the pointers! |
frenck
previously approved these changes
Jun 21, 2019
MartinHjelmare
requested changes
Jun 25, 2019
source/_components/vallox.markdown
Outdated
| required: false | ||
| default: Vallox | ||
| type: string | ||
| sensors: |
There was a problem hiding this comment.
This option was removed.
MartinHjelmare
previously approved these changes
Jun 25, 2019
|
Thanks for the PR @andre-richter! Well done 👍 |
frenck
approved these changes
Jun 28, 2019
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Accompanying documentation for the new integration PR for Vallox ventilation units.
Pull request in home-assistant (if applicable): home-assistant/core#24660
Checklist:
nextis for changes and new documentation that will go public with the next home-assistant release. Fixes, changes and adjustments for the current release should be created againstcurrent.