-
-
Notifications
You must be signed in to change notification settings - Fork 2k
Closed
Description
Analysis
It is not possible to update platform accessories because the method handleUpdatePlatformAccessories()
is not properly implemented:
// eslint-disable-next-line @typescript-eslint/no-unused-vars
handleUpdatePlatformAccessories(accessories: PlatformAccessory[]): void {
// Update persisted accessories
this.saveCachedPlatformAccessoriesOnDisk();
}
In this method, the array of PlatformAccessory
objects is lost, as it is not used in the handleUpdatePlatformAccessories()
method. The method just saves the currently cached platform accessories back to disc without updating anything.
Even worse, the method is commented with a sweep-issues-under-the-rug
annotation:
// eslint-disable-next-line @typescript-eslint/no-unused-vars
Expected Behavior
handleUpdatePlatformAccessories()
should take the passed in array of PlatformAccessory
objects and update the appropriate cached accessories before saving them back to disk.
Steps To Reproduce
N/A
Logs
N/A
Configuration
N/A
Environment
- OS: N/A
- Homebridge: 1.8.5
- Node: N/A
- npm: N/A
Process Supervisor
not applicable
Additional Context
No response