Finish fixing #214 - workaround for bug in IE8 iframe onload implementation

Dave Gurnell · Dave Gurnell · commit 8ddf48fff822 · 2014-03-07T13:16:16.000Z
Reorder the code that sets up the iframe onload handler to ensure
the handler is defined before the iframe is added to the window.
diff --git a/lib/FileAPI.XHR.js b/lib/FileAPI.XHR.js
@@ -96,29 +96,6 @@
 				// legacy
 				options.upload(options, _this);
 
-				xhr = document.createElement('div');
-				xhr.innerHTML = '<form target="'+ uid +'" action="'+ url +'" method="POST" enctype="multipart/form-data" style="position: absolute; top: -1000px; overflow: hidden; width: 1px; height: 1px;">'
-							+ '<iframe name="'+ uid +'" src="javascript:false;" onload="' + onloadFuncName + '()"></iframe>'
-							+ (jsonp && (options.url.indexOf('=?') < 0) ? '<input value="'+ uid +'" name="'+jsonp+'" type="hidden"/>' : '')
-							+ '</form>'
-				;
-
-				// get form-data & transport
-				var
-					  form = xhr.getElementsByTagName('form')[0]
-					, transport = xhr.getElementsByTagName('iframe')[0]
-				;
-
-				form.appendChild(data);
-
-				api.log(form.parentNode.innerHTML);
-
-				// append to DOM
-				document.body.appendChild(xhr);
-
-				// keep a reference to node-transport
-				_this.xhr.node = xhr;
-
 				var
 					onPostMessage = function (evt){
 						if( ~url.indexOf(evt.origin) ){
@@ -169,6 +146,29 @@
 					}
 				};
 
+				xhr = document.createElement('div');
+				xhr.innerHTML = '<form target="'+ uid +'" action="'+ url +'" method="POST" enctype="multipart/form-data" style="position: absolute; top: -1000px; overflow: hidden; width: 1px; height: 1px;">'
+							+ '<iframe name="'+ uid +'" src="javascript:false;" onload="' + onloadFuncName + '()"></iframe>'
+							+ (jsonp && (options.url.indexOf('=?') < 0) ? '<input value="'+ uid +'" name="'+jsonp+'" type="hidden"/>' : '')
+							+ '</form>'
+				;
+
+				// get form-data & transport
+				var
+					  form = xhr.getElementsByTagName('form')[0]
+					, transport = xhr.getElementsByTagName('iframe')[0]
+				;
+
+				form.appendChild(data);
+
+				api.log(form.parentNode.innerHTML);
+
+				// append to DOM
+				document.body.appendChild(xhr);
+
+				// keep a reference to node-transport
+				_this.xhr.node = xhr;
+
 				// send
 				_this.readyState = 2; // loaded
 				form.submit();
