Cleanup: remove getattr anti-pattern

jayaddison · jayaddison · commit 5f4ace937520 · 2020-12-30T16:47:44.000Z
diff --git a/html5lib/_tokenizer.py b/html5lib/_tokenizer.py
@@ -31,6 +31,7 @@ def __init__(self, data=None):
 class Doctype(Token):
     def __init__(self, name, public_id, system_id, correct):
         self.name = name.translate(asciiUpper2Lower)
+        self.namespace = None
         self.public_id = public_id
         self.system_id = system_id
         self.correct = correct
@@ -45,6 +46,7 @@ class SpaceCharacters(Token):
 class Tag(Token):
     def __init__(self, name, attributes):
         self.name = name.translate(asciiUpper2Lower)
+        self.namespace = None
         self.attributes = attributeMap(attributes or {})
         self.self_closing = False
         self.attribute_name = ""
diff --git a/html5lib/treebuilders/base.py b/html5lib/treebuilders/base.py
@@ -301,7 +301,7 @@ def insertComment(self, token, parent=None):
     def createElement(self, token):
         """Create an element but don't insert it anywhere"""
         name = token.name
-        namespace = getattr(token, "namespace", self.defaultNamespace)
+        namespace = token.namespace or self.defaultNamespace
         element = self.elementClass(name, namespace)
         element.attributes = token.attributes
         return element
@@ -323,7 +323,7 @@ def _setInsertFromTable(self, value):
     def insertElementNormal(self, token):
         name = token.name
         assert isinstance(name, text_type), "Element %s not unicode" % name
-        namespace = getattr(token, "namespace", self.defaultNamespace)
+        namespace = token.namespace or self.defaultNamespace
         element = self.elementClass(name, namespace)
         element.attributes = token.attributes
         self.openElements[-1].appendChild(element)
diff --git a/html5lib/treebuilders/etree_lxml.py b/html5lib/treebuilders/etree_lxml.py
@@ -375,7 +375,7 @@ def insertRoot(self, token):
 
         # Give the root element the right name
         name = token.name
-        namespace = getattr(token, "namespace", self.defaultNamespace)
+        namespace = token.namespace or self.defaultNamespace
         if namespace is None:
             etree_tag = name
         else:
