refactoring code with For Else

idiomaticrefactoring · web-flow · commit 7d69da2c7517 · 2022-01-22T22:19:01.000+08:00
refactoring code with For Else which is more pythonic, concise and efficient; how do you think this change which has practical value？
diff --git a/html5lib/_ihatexml.py b/html5lib/_ihatexml.py
@@ -104,16 +104,16 @@ def charStringToList(chars):
     charRanges = [item.strip() for item in chars.split(" | ")]
     rv = []
     for item in charRanges:
-        foundMatch = False
+        
         for regexp in (reChar, reCharRange):
             match = regexp.match(item)
             if match is not None:
                 rv.append([hexToInt(item) for item in match.groups()])
                 if len(rv[-1]) == 1:
                     rv[-1] = rv[-1] * 2
-                foundMatch = True
+                
                 break
-        if not foundMatch:
+        else:
             assert len(item) == 1
 
             rv.append([ord(item)] * 2)
