Fix ElementTree treewalker under cElementTree on Python 2.6.

gsnedders · gsnedders · commit b8f8e3d76f11 · 2013-04-13T22:17:46.000+01:00
This is effectively the treewalker equivalent of 3e50aad: Don't rely on the ElementTree Comment factory being the tag attribute on Comments. This is needed for xml.etree.cElementTree under 2.6 (and likely hence custom installs of cElementTree 1.2), where the tag property is equal to xml.etree.ElementTree.Comment (i.e., the pure Python version).
diff --git a/html5lib/treewalkers/etree.py b/html5lib/treewalkers/etree.py
@@ -15,6 +15,7 @@
 
 def getETreeBuilder(ElementTreeImplementation):
     ElementTree = ElementTreeImplementation
+    ElementTreeCommentType = ElementTree.Comment("asd").tag
 
     class TreeWalker(_base.NonRecursiveTreeWalker):
         """Given the particular ElementTree representation, this implementation,
@@ -48,7 +49,7 @@ def getNodeDetails(self, node):
                 return (_base.DOCTYPE, node.text,
                         node.get("publicId"), node.get("systemId"))
 
-            elif node.tag == ElementTree.Comment:
+            elif node.tag == ElementTreeCommentType:
                 return _base.COMMENT, node.text
 
             else:
