Critic review: https://critic.hoppipolla.co.uk/r/521

This is an external review system which you may optionally use for the code review of your pull request.

In order to help critic track your changes, please do not make in-place history rewrites (e.g. via git rebase -i or git commit --amend) when updating this pull request.

Note that the e.name attribute of webencodingd.Encoding objects is the name in http://encoding.spec.whatwg.org/.

Not all such names are recognized in Python. e.codec_info.name is, except for the x-user-defined encoding that does not exist in Python and webencoding defines. To fix that, use eg. e.codec_info.streamreader instead of codecs.getreader(). (Not that x-user-defined is very useful anyway…)

Still, documentEncoding (#123) should be the spec name, or even the Encoding object.

Note without html5lib/html5lib-tests#40 this fails a fair number of tests.

Repository health decreased by 0.54% when pulling 2abaeae on gsnedders:webencodings into 46dae3d on html5lib:master.

• 2 new problems were found (including 1 error and 1 code smell).
• 5 problems were fixed (including 1 error and 4 code smells).

Build seems to be passing with XPASSes, hmm.

Repository health decreased by 0.54% when pulling d659cf3 on gsnedders:webencodings into 46dae3d on html5lib:master.

• 2 new problems were found (including 1 error and 1 code smell).
• 5 problems were fixed (including 1 error and 4 code smells).

Repository health decreased by 0.54% when pulling ff8bbf8 on gsnedders:webencodings into 46dae3d on html5lib:master.

• 2 new problems were found (including 1 error and 1 code smell).
• 5 problems were fixed (including 1 error and 4 code smells).

@jgraham r?