Skip to content

setup.py: Require ordereddict for Python 2.6 #177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 12, 2014
Merged

setup.py: Require ordereddict for Python 2.6 #177

merged 1 commit into from
Dec 12, 2014

Conversation

msabramo
Copy link
Contributor

Without this, a client who uses the alphabetical attribute sorting feature of HTMLSerializer on Python 2.6 will get:

  File "/Users/marca/dev/git-repos/bleach/.tox/py26/lib/python2.6/site-packages/html5lib/serializer/htmlserializer.py", line 309, in render
    return "".join(list(self.serialize(treewalker)))
  File "/Users/marca/dev/git-repos/bleach/.tox/py26/lib/python2.6/site-packages/html5lib/serializer/htmlserializer.py", line 196, in serialize
    from ..filters.alphabeticalattributes import Filter
  File "/Users/marca/dev/git-repos/bleach/.tox/py26/lib/python2.6/site-packages/html5lib/filters/alphabeticalattributes.py", line 8, in <module>
    from ordereddict import OrderedDict
ImportError: No module named ordereddict

@hoppipolla-critic-bot
Copy link

Critic review: https://critic.hoppipolla.co.uk/r/3483

This is an external review system which you may optionally use for the code review of your pull request.

In order to help critic track your changes, please do not make in-place history rewrites (e.g. via git rebase -i or git commit --amend) when updating this pull request.

msabramo added a commit to msabramo/bleach that referenced this pull request Dec 12, 2014
@msabramo
setup.py: Add ordereddict dependency
b34286f 
because html5lib needs it for alpha-sorted attributes when on Python 2.6
and it doesn't specify it as a dependency (see
html5lib/html5lib-python#177)
msabramo added a commit to msabramo/bleach that referenced this pull request Dec 12, 2014
@msabramo
setup.py: Add ordereddict dependency
bbe00c0 
because html5lib needs it for alpha-sorted attributes when on Python 2.6
and it doesn't specify it as a dependency (see
html5lib/html5lib-python#177)
jgraham added a commit that referenced this pull request Dec 12, 2014
@jgraham
Merge pull request #177 from msabramo/require_ordereddict_for_py26
3b3c103 
setup.py: Require ordereddict for Python 2.6
@jgraham jgraham merged commit 3b3c103 into html5lib:master Dec 12, 2014
@jsocol jsocol mentioned this pull request Dec 12, 2014
Merged
@gsnedders
Copy link
Member

This really shouldn't have been r+'d/merged… This needs a changelog entry, the readme needs to be updated so it's accurate, and the requirements*.txt files need updating.

@gsnedders gsnedders mentioned this pull request Jan 11, 2015
Closed
gsnedders added a commit that referenced this pull request Apr 29, 2015
@gsnedders
Revert "Merge pull request #177 from msabramo/require_ordereddict_for…
165bf4c 
…_py26"

This reverts commit 3b3c103, reversing
changes made to 7cce65b.

Revert this till #179 is sorted.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@msabramo @hoppipolla-critic-bot @gsnedders @jgraham